#2555 Headless Server should unregister #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
force-pushed
the
bugfix/unregister-on-sigint
branch
from
7752a01 to
5e39b08
Compare
hoffie
approved these changes
May 19, 2022
pljones
force-pushed
the
bugfix/unregister-on-sigint
branch
from
5e39b08 to
d23ec6a
Compare
pljones
force-pushed
the
bugfix/unregister-on-sigint
branch
from
d23ec6a to
f208d53
Compare
pljones
force-pushed
the
bugfix/unregister-on-sigint
branch
from
f208d53 to
5b51386
Compare
ann0see
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Currently, when a registered server is terminated, it doesn't send an "unregister" to the directory. This means that there can be "ghost" entries for a while (visible with
--showallserversor on Jamulus Explorer). This fix adds the necessary request to the existingOnAboutToQuit()handler.CHANGELOG: Headless Server now unregisters correctly
Context: Fixes an issue?
Fixes: 2555
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested and has been running on my servers for months.
What is missing until this pull request can be merged?
Can be merged.
Checklist