Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading serverlist entry from CSV file #2631

Merged

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented May 16, 2022

Short description of changes

The server list persistence code has a but that causes corruption of the server name and city when the file is read. It truncates the base64-encoded value to the max field length -- before decoding it

This fixes the code to truncate after decoding.

CHANGELOG: Fix loading of persistent server list entries

Context: Fixes an issue?

See above.

Does this change need documentation? What needs to be documented and how?

No. Fix for existing feature.

Status of this Pull Request

Test and running on all my directories.

What is missing until this pull request can be merged?

Approvals.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.9.0 milestone May 16, 2022
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the assumption it is well tested (looks trivial)

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, in hindsight the fix looks obvious... ;)

@ann0see ann0see merged commit 2505ad6 into jamulussoftware:master May 16, 2022
@pljones
Copy link
Collaborator Author

pljones commented May 17, 2022

Yeah, I was testing something else and kept seeing this truncation happening. Eventually looked at this bit of the code and went "...D'uh..."

@pljones pljones deleted the bugfix/load-serverlist-from-csv branch May 17, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants