Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove translation from CLI version text #2602

Merged
merged 1 commit into from
May 19, 2022
Merged

Remove translation from CLI version text #2602

merged 1 commit into from
May 19, 2022

Conversation

henkdegroot
Copy link
Contributor

@henkdegroot henkdegroot commented Apr 18, 2022 •
edited by ann0see
Loading

Short description of changes
Remove the translation for the CLI version text output

CHANGELOG: Client: Remove the translation for the CLI version text output

Context: Fixes an issue?
Fixes #2319

Does this change need documentation? What needs to be documented and how?
No

Status of this Pull Request
Waiting on second review

What is missing until this pull request can be merged?
Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@henkdegroot
Copy link
Contributor Author

Sample of the CLI version output in windows:

image

@ann0see ann0see added this to the Release 3.9.0 milestone Apr 19, 2022
ann0see
ann0see reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One time we should also add the uses ASIO/copyright statement conditionally.

@ann0see ann0see self-requested a review April 19, 2022 21:11
@henkdegroot
Copy link
Contributor Author

Asio text to be added as part of the Asio PR I will be doing for updating the installer and About dialog.

@ann0see ann0see requested a review from hoffie April 20, 2022 08:57
@henkdegroot henkdegroot force-pushed the remove-translation-cli branch from 7ef5603 to 91b39a7 Compare April 22, 2022 18:54
@ann0see
Copy link
Member

ann0see commented May 7, 2022

@hoffie could you please review this PR?

@ann0see ann0see merged commit 039c186 into jamulussoftware:master May 19, 2022
@henkdegroot henkdegroot deleted the remove-translation-cli branch May 20, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pljones pljones pljones approved these changes

@ann0see ann0see ann0see approved these changes

@hoffie hoffie Awaiting requested review from hoffie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Translation of GPL preamble in GUI and CLI
3 participants
@henkdegroot @ann0see @pljones