Autobuild: Combine and simplify Android build scripts #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
reviewed
Mar 19, 2022
| pass_artifact_to_job | ||
| ;; | ||
| *) | ||
| echo "Unknown stage '${1:-}'" |
There was a problem hiding this comment.
Although this would apply to all scripts: We should probably output something like "NOTE: This script is designed to run on GitHub Actions, not locally. Please run the deploy scripts in the respective OS folder"
Related: jamulussoftware#2503 - Move all autobuild/android/* scripts to a single .github/autobuild/android.sh script which is called for the different stages (setup/build/get-artifacts). - Create functions with proper names for larger steps - Inline Github artifact output definition as it's shorter that way - Make shellcheck-clean - Drop wget dependency and use curl for all downloads - Keep variables as local as possible; only export what's necessary - Move further hardcoded versions to variables - Move build output to build/ - Drop dependencies libxkbcommon-x11-0 (unused) and openjdk-8-jre-headless (covered via jdk)
Now that all platforms have been converted to the new scheme (.github/autobuild/*), the autobuild directory only contains the ensure_THIS_JAMULUS_PROJECT_PATH.sh script which is no longer used. Related: jamulussoftware#2521
hoffie
force-pushed
the
autobuild-merge-android-scripts
branch
from
0097888 to
7803eb5
Compare
6 tasks
22 tasks
ann0see
approved these changes
Mar 19, 2022
9 tasks
pljones
approved these changes
Mar 22, 2022
hoffie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Move all autobuild/android/* scripts to a single
.github/autobuild/android.sh script which is called for the different stages
(setup/build/get-artifacts).
Create functions with proper names for larger steps
Inline Github artifact output definition as it's shorter that way
Make shellcheck-clean
Drop wget dependency and use curl for all downloads
Keep variables as local as possible; only export what's necessary
Move further hardcoded versions to variables
And as this is also the last PR which converts the platform-specific scripts, this includes the now possible cleanup:
Now that all platforms have been converted to the new scheme (.github/autobuild/*), the autobuild directory only contains the
ensure_THIS_JAMULUS_PROJECT_PATH.sh script which is no longer used.
CHANGELOG: Autobuild: Refactored and simplified Android build scripts.
(will be condensed...)
Context: Fixes an issue?
Related: #2521
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Reviews.
Checklist