Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows/qt-installer-windows.qs since no longer used #2516

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Mar 16, 2022

Short description of changes
Since Travis Ci is no longer used, the qt-installer-windows.qs file is no longer needed.

CHANGELOG: Internal: Removed outdated qt-installer-windows.qs since we no longer use Travis CI
Context: Fixes an issue?
Fixes: #2515

Does this change need documentation? What needs to be documented and how?
Yes. The COMPILING.md file should be updated.

Status of this Pull Request
Ready for review

What is missing until this pull request can be merged?
Nothing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Since Travis Ci is no longer used, the qt-installer-windows.qs file is no longer needed.

Fixes: jamulussoftware#2515
@ann0see ann0see added this to the Release 3.9.0 milestone Mar 16, 2022
@hoffie
Copy link
Member

hoffie commented Mar 16, 2022

I usually argue against "can you additionally do $OTHER_THING" in PRs, but in this case I think at least the closely related updating part of COMPILING.md could be done as part of this PR?

I.e. remove the reference to this file and replace it with a reference to the Windows autobuild script?

@ann0see
Copy link
Member Author

ann0see commented Mar 17, 2022

@hoffie I did not add the autobuild script but a reference to Qt 5.15.2. I think we should update this file and not direct the user to some files in Git.

@ann0see ann0see requested a review from hoffie March 17, 2022 19:53
@ann0see ann0see merged commit 7f3ebba into jamulussoftware:master Mar 18, 2022
@ann0see ann0see deleted the patch/removeQtInstaller branch March 18, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Remove windows/qt-installer-windows.qs / Update COMPILING.md?
3 participants