JSON-RPC: Add server directory name (issue #2467) #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-NY
changed the title
pljones
reviewed
Mar 13, 2022
pljones
approved these changes
Mar 14, 2022
hoffie
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Thanks! Code looks good. Tested:
- Non-registered server
- Registered to public directory
- Registered to custom directory
Also thanks for the apiAuth documentation fix. I had missed that previously. :)
CHANGELOG: JSON-RPC: Extended jamulusserver/getServerProfile method to include directoryServer name for registration requests.
hoffie
force-pushed
the
rpc_server_directory_name_2467
branch
from
503c464 to
5200702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Addresses directory server name in issue #2467 and fixes minor doc issue. Regenerated JSON-RPC doc using tools python script.
CHANGELOG: Extended JSON-RPC jamulusserver/getServerProfile method to include directoryServer name for registration requests.
Context: Fixes an issue?
Fixes: #2467
Does this change need documentation? What needs to be documented and how?
Auto-documented using python doc tool for JSON-RPC.
Status of this Pull Request
What is missing until this pull request can be merged?
Tested on Linux only.
Checklist