Autobuild: Don't cache pip #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the pip cache to the action/cache path list is unnecessary. pip is only run when Qt is missing (= cache miss) and aqtinstall must be downloaded.
pljones
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This removes the pip cache from Mac and Windows action/cache jobs.
Adding the pip cache to the action/cache path list is unnecessary. pip is only run when Qt is missing (= cache miss) and aqtinstall must be downloaded.
CHANGELOG: Autobuild: Optimized build caching.
(Entry will likely be condensed...)
Context: Fixes an issue?
Saves cache storage / improves cache restore/save performance.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready on CI green.
What is missing until this pull request can be merged?
Ready on CI green.
Checklist