-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Parallelize compilation on Android, Mac (CodeQL) and Debian #2444
Conversation
Interesting it works. I tried it once and the CI ran out of resources. But if it works now that’s great (I.e the build time gets ok-ish time wise) |
Maybe hardware specs have changed (Mac seems to use 3 cores, other platforms 2 cores) or another
The examples show an improvement, but there is lots of flakiness in build times, so it's hard to tell for sure and how much the benefit is. Anyway, some of the build scripts are also used locally and not only in autobuild, so it makes sense to add it anyway. |
I think @pljones or I used plain -j |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is green (but I still get confused whether it's using the "to be merged" CI components when doing CI on CI components or whether it's using the existing ones).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it uses the one in the PR.
That's what I use locally as well. I thought it had some automatism for figuring out a good
Pretty sure it's the to-be-merged ones. Besides .github/, Github has no way to figure out what else is "CI related". I think you might be referring to the logic that PRs ( |
Short description of changes
This PR modifies the
make
calls to use a-jN
paramter to parallelize builds.-j
, but I'll try to do something similar usingjom
.CHANGELOG: Internal: Speed up Debian, Mac & Android build processes by using parallelization.
Context: Fixes an issue?
Performance
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready.
Note: Build times do vary so take these numbers with a grain of salt.
What is missing until this pull request can be merged?
Reviews.
Checklist