Make server GUI default to "None" directory if not set. #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jamulussoftware#2441. If the directory is not set in the ini file or the command line, the server should not automatically register to All Genres 1. It should default to not registering until the user actually chooses a directory.
pljones
reviewed
Feb 28, 2022
pljones
reviewed
Feb 28, 2022
pljones
reviewed
Feb 28, 2022
pljones
approved these changes
Mar 3, 2022
hoffie
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Looks good to me.
Tested:
- This PR with empty ini: registration is disabled.
- 3.8.2 with registration disabled stays disables with this PR
- 3.8.2 with registration on public directory stays like this with this PR
- 3.8.2 with registration on custom directory stays like this with this PR
What, not with 3.4.5? ;) Nice work, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
If the directory is not set in the ini file or the command line, the server should not automatically register to All Genres 1. It should default to not registering until the user actually chooses a directory.
This PR sets the default for the GUI accordingly.
CHANGELOG: Server: Set default directory to "None" when not set in ini file or command line.
Context: Fixes an issue?
Fixes #2441
Does this change need documentation? What needs to be documented and how?
Probably not.
Status of this Pull Request
Tested and ready
What is missing until this pull request can be merged?
Checklist