Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/get_release_contributors.py: Clarify docs and ignore ImgBotApp & actions-bot #2411

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

hoffie
Copy link
Member

@hoffie hoffie commented Feb 20, 2022

Updates the tools/get_release_contributors.py release helper script:

  • to clarify usage (we missed the website contributors in the first run)
  • update usage for the new website process (no more translate* branches)
  • to ignore two more bot users which should not be mentioned.

CHANGELOG: Internal: Improved release contributor tooling

@hoffie hoffie added this to the Release 3.9.0 milestone Feb 20, 2022
@hoffie hoffie requested review from gilgongo and ann0see February 20, 2022 20:36
@hoffie hoffie force-pushed the ignore-bot-contributors branch from 1c13397 to 42f2aa0 Compare February 20, 2022 20:54

## Website repo (jamulussoftware/jamuluswebsite)
- cd jamuluswebsite
- git log release # Find commit ID of previous version. Search for RELEASE:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --graph might make the log easier (not sure on that). Also specifying a --format that limits the result to one line per commit, so long as the info is sufficient (if you're not generally a git user, you may not be familiar with configuring your got log format). RELEASE: should probably be in quotes to show it's a literal to search for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --graph might make the log easier (not sure on that).

Hm, tried with --graph, not too convinced about the benefits in this case.

Also specifying a --format that limits the result to one line per commit, so long as the info is sufficient (if you're not generally a git user, you may not be familiar with configuring your got log format).

Added --oneline

RELEASE: should probably be in quotes to show it's a literal to search for.

Done.

@hoffie hoffie force-pushed the ignore-bot-contributors branch from 42f2aa0 to 0ca2870 Compare February 20, 2022 21:39
@hoffie hoffie requested review from ann0see and pljones February 26, 2022 15:56
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like actions-user also needs to be ignored:

tony@pi:~/jamulus $ ./tools/get_release_contributors.py --from r3_8_1 --to r3_8_2 --repo .
Code contributors: @actions-user @ann0see @atsampson @BLumia @corrados @DavidSavinkoff @djfun @gilgongo @henkdegroot @hoffie @j-santander @mirabilos @ngocdh @npostavs @pljones @Rob-NY @RobyDati @softins
Application translators: @actions-user @ann0see @BLumia @dzpex @henkdegroot @hoffie @ignotus666 @jose1711 @jujudusud @melcon @pljones @rolamos @SeeLook @softins

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that much...

@hoffie hoffie force-pushed the ignore-bot-contributors branch from 0ca2870 to f42f983 Compare March 6, 2022 08:57
@hoffie hoffie merged commit a2f8b04 into jamulussoftware:master Mar 9, 2022
@hoffie hoffie deleted the ignore-bot-contributors branch March 9, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants