Add link to website if a new version is available #1980

ann0see · 2021-08-27T18:38:48Z

Short description of changes

Adds a clickable link in the "new jamulus version available" message:

I think it would be good to have this one in the next release.

Context: Fixes an issue?

Sometimes users might find it confusing to only get notified that a new version is available but no actionable "solution" is provided. Therefore this will add a link to a page which is still to be created (currently just a redirect to jamulus.io).

Also see: #370 (comment)

Does this change need documentation? What needs to be documented and how?

Screenshots needed???
CHANGELOG: Link download page in "update available" message to make updating easier

Status of this Pull Request

Working implementation.

What is missing until this pull request can be merged?
Two approvals.

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

pljones · 2021-08-27T19:22:19Z

I'd prefer wording like "A Jamulus upgrade is available: click for details". Definitely without the exclamation mark (implies being commanded to something).

ann0see · 2021-08-27T19:24:49Z

Yes. Can change that.

However the question is how the "click for details" page should look like. But that's something I need to worry about on the webpage.

ann0see · 2021-08-27T19:28:17Z

Ok. Changed it. Need to wait until autobuild is finished.

ann0see · 2021-08-27T20:02:39Z

Windows autobuild failed. Hopefully an update of the ASIO sdk will fix it: ann0see@2583800

Ok. Download the artifacts here: https://github.com/ann0see/jamulus/releases/tag/r_link-download-page
(with faked version 3.0.0) to show the update message.

ann0see · 2021-08-27T20:53:55Z

Ok. See the updated screenshot above.
Edit: fixed some spacing issues- hopefully. They weren’t included in the screenshot yet, but adding should be trivial.

ann0see · 2021-08-27T20:55:34Z

@gilgongo I think that‘s something for you?

pljones · 2021-08-28T07:26:59Z

src/serverdlg.cpp

-    lblUpdateCheck->setText ( "<font color=\"red\"><b>" + QString ( APP_NAME ) + " " + tr ( "software upgrade available" ) + "</b></font>" );
+    lblUpdateCheck->setOpenExternalLinks ( true ); // enables opening a web browser if one clicks on a html link
+    lblUpdateCheck->setText (
+        "<font color=\"#c94a55\"><b>" + tr ( "A %1 upgrade is available:&nbsp;" ).arg ( APP_NAME ) +


Why is the font colour changing?

The "red" didn’t fit to the mixer background contrast wise. But we can also agree on another colour.

Ideally we'd have a stylesheet (managed at application level) with a class... But if it's got to be an explicit hex code to look right, fine.

Yeah. But that's out of scope here probably. I think you should open an issue (and maybe even tag it as "good first issue" since I think it's easy to implement)

src/serverdlg.cpp

gilgongo

Looks good.

ann0see · 2021-08-31T19:02:44Z

Do we want to add a build version (with JACK, OS,...) as GET argument to the URL? This would enable us to automatically redirect the user to the correct download on jamulus.io

e.g.:

https://jamulus.io/upgrade?progversion=3.8.1&build=windows_jack while build= could also be a md5 hash of CONFIG QSysInfo::productType()

ann0see · 2021-09-01T10:57:00Z

Used the wrong argument for the version on the update url. Should be fixed now.

src/serverdlg.cpp

src/clientdlg.cpp

pljones · 2021-09-02T06:17:33Z

For testing, build locally with Jamulus.pro VERSION = 3.7.99 and check you get told 3.8.0 is available.

src/global.h

ann0see · 2021-09-02T14:04:25Z

Before we merge this 72e4ac1 needs to be reverted. However, now we have it as test commit

* Update clientdlg.cpp * Update serverdlg.cpp * Update global.h * Spacing

pljones · 2021-09-02T17:41:40Z

So grab the artifact from the builds, run it as client and server, and let us know.

ann0see · 2021-09-02T18:25:42Z

Yup. Works as expected.

ann0see · 2021-09-02T18:26:57Z

Should be squash & merged.

ann0see · 2021-09-02T18:28:34Z

I'm still not 100% sure about the color/contrast of the message. I'll revert it to red but maybe a @jamulussoftware/designers might give a proposal (preferably in another PR)

mulyaj · 2021-09-02T19:02:27Z

I just took a look here, and the current contrast ratio is 4.01:1.

Ideally, to be pass WCAG AA guidelines for normal text (~18px) you'd want a ratio of >4.5:1. I'd advise against a full tinted red, as I think it'd make the ratio worse.

A darker red (or something in this range) like #AB202C can work.

jamulussoftware#1980 (comment)

ann0see · 2021-09-02T21:19:59Z

Yes. Looks much better now! Thanks

mulyaj · 2021-09-02T21:43:06Z

Oh, I didn't consider the color for the different skins.

I don't think the dark red I suggested works with the fancy skin. Are you open to using different colors for normal and fancy? Or would you prefer a color that encompasses both skins?

pljones · 2021-09-02T22:02:55Z

Oh, I didn't consider the color for the different skins.

I don't think the dark red I suggested works with the fancy skin. Are you open to using different colors for normal and fancy? Or would you prefer a color that encompasses both skins?

I was going to ask.... Here it's not skinned. It was partly why I was thinking the styling should be passed as an argument (though I'd pulled all the HTML out), to make it easier to apply skinning.

ann0see · 2021-09-03T07:41:32Z

It’s not that bad IMHO, but I think it’s out of scope of this PR to make the colours changable (since this would also involve the mute myself bar).

pljones · 2021-09-03T07:52:02Z

It’s not that bad IMHO, but I think it’s out of scope of this PR to make the colours changable (since this would also involve the mute myself bar).

The server recording highlight is on the mixer panel, so I guess that's elsewhere, but that's skin-dependent, IIRC.

Stick with whatever colour is used in the Mute Myself indicator so at least we know it's meant to be the same in future.

ann0see · 2021-09-03T11:29:20Z

Ok. Reverted it back to "red". See updated screenshots.

ann0see · 2021-09-03T19:08:47Z

Thanks! I think this should have been squashed 😉

pljones · 2021-09-04T20:26:20Z

Mmmm.... 😁

ann0see force-pushed the feature/link-download-page branch from 20d576c to c4c4bf6 Compare August 27, 2021 19:07

ann0see force-pushed the feature/link-download-page branch from c4c4bf6 to bfeed76 Compare August 27, 2021 19:16

ann0see force-pushed the feature/link-download-page branch from bfeed76 to d112825 Compare August 27, 2021 19:27

ann0see force-pushed the feature/link-download-page branch from d112825 to 6d0b21b Compare August 27, 2021 20:59

pljones reviewed Aug 28, 2021

View reviewed changes

src/serverdlg.cpp Outdated Show resolved Hide resolved

pljones added this to the Release 3.8.1 milestone Aug 29, 2021

pljones added the improvement label Aug 29, 2021

ann0see force-pushed the feature/link-download-page branch 2 times, most recently from 795626f to 9a16ea2 Compare August 31, 2021 18:56

ann0see requested review from gilgongo and pljones August 31, 2021 18:57

gilgongo approved these changes Aug 31, 2021

View reviewed changes

ann0see force-pushed the feature/link-download-page branch from 9a16ea2 to 2ccecd2 Compare September 1, 2021 10:56

pljones reviewed Sep 1, 2021

View reviewed changes

src/serverdlg.cpp Outdated Show resolved Hide resolved

ann0see force-pushed the feature/link-download-page branch 2 times, most recently from d92919a to 6a95ba4 Compare September 1, 2021 21:40

ignotus666 reviewed Sep 2, 2021

View reviewed changes

src/clientdlg.cpp Outdated Show resolved Hide resolved

ignotus666 reviewed Sep 2, 2021

View reviewed changes

src/global.h Outdated Show resolved Hide resolved

Link upgrade page if new version is available

89a201a

ann0see force-pushed the feature/link-download-page branch from 6a95ba4 to 89a201a Compare September 2, 2021 13:58

Fake old version

72e4ac1

ignotus666 and others added 2 commits September 2, 2021 18:04

Make constant translatable (#31)

f745912

* Update clientdlg.cpp * Update serverdlg.cpp * Update global.h * Spacing

Apply clang format

5df02a1

Revert fake version

725494f

Use styling by @mulyaj

81c52d5

jamulussoftware#1980 (comment)

Revert color styling

efe06ff

pljones approved these changes Sep 3, 2021

View reviewed changes

pljones merged commit f9ed108 into jamulussoftware:master Sep 3, 2021

ann0see deleted the feature/link-download-page branch September 3, 2021 19:08

gilgongo linked an issue Sep 14, 2021 that may be closed by this pull request

Version check for disconnected environments #1178

Open

gilgongo mentioned this pull request Sep 14, 2021

Version check for disconnected environments #1178

Open

ann0see mentioned this pull request Nov 28, 2021

Create a basic download page jamulussoftware/jamuluswebsite#644

Closed

2 tasks

pljones removed a link to an issue May 6, 2024

Version check for disconnected environments #1178

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add link to website if a new version is available #1980

Add link to website if a new version is available #1980

ann0see commented Aug 27, 2021 •

edited

Loading

pljones commented Aug 27, 2021

ann0see commented Aug 27, 2021

ann0see commented Aug 27, 2021

ann0see commented Aug 27, 2021 •

edited

Loading

ann0see commented Aug 27, 2021 •

edited

Loading

ann0see commented Aug 27, 2021

pljones Aug 28, 2021

ann0see Aug 29, 2021

pljones Aug 29, 2021 •

edited

Loading

ann0see Aug 31, 2021

gilgongo left a comment

ann0see commented Aug 31, 2021 •

edited

Loading

ann0see commented Sep 1, 2021

pljones commented Sep 2, 2021

ann0see commented Sep 2, 2021

pljones commented Sep 2, 2021

ann0see commented Sep 2, 2021

ann0see commented Sep 2, 2021

ann0see commented Sep 2, 2021

mulyaj commented Sep 2, 2021

ann0see commented Sep 2, 2021

mulyaj commented Sep 2, 2021

pljones commented Sep 2, 2021 •

edited

Loading

ann0see commented Sep 3, 2021

pljones commented Sep 3, 2021

ann0see commented Sep 3, 2021

ann0see commented Sep 3, 2021

pljones commented Sep 4, 2021

Add link to website if a new version is available #1980

Add link to website if a new version is available #1980

Conversation

ann0see commented Aug 27, 2021 • edited Loading

Checklist

pljones commented Aug 27, 2021

ann0see commented Aug 27, 2021

ann0see commented Aug 27, 2021

ann0see commented Aug 27, 2021 • edited Loading

ann0see commented Aug 27, 2021 • edited Loading

ann0see commented Aug 27, 2021

pljones Aug 28, 2021

Choose a reason for hiding this comment

ann0see Aug 29, 2021

Choose a reason for hiding this comment

pljones Aug 29, 2021 • edited Loading

Choose a reason for hiding this comment

ann0see Aug 31, 2021

Choose a reason for hiding this comment

gilgongo left a comment

Choose a reason for hiding this comment

ann0see commented Aug 31, 2021 • edited Loading

ann0see commented Sep 1, 2021

pljones commented Sep 2, 2021

ann0see commented Sep 2, 2021

pljones commented Sep 2, 2021

ann0see commented Sep 2, 2021

ann0see commented Sep 2, 2021

ann0see commented Sep 2, 2021

mulyaj commented Sep 2, 2021

ann0see commented Sep 2, 2021

mulyaj commented Sep 2, 2021

pljones commented Sep 2, 2021 • edited Loading

ann0see commented Sep 3, 2021

pljones commented Sep 3, 2021

ann0see commented Sep 3, 2021

ann0see commented Sep 3, 2021

pljones commented Sep 4, 2021

ann0see commented Aug 27, 2021 •

edited

Loading

ann0see commented Aug 27, 2021 •

edited

Loading

ann0see commented Aug 27, 2021 •

edited

Loading

pljones Aug 29, 2021 •

edited

Loading

ann0see commented Aug 31, 2021 •

edited

Loading

pljones commented Sep 2, 2021 •

edited

Loading