Fix Ampersand not being shown correctly #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
bugfix/1886-ReplaceAmpersand
branch
2 times, most recently
from
a149af2 to
c7e884a
Compare
If a server-name contained '&' this was interpreted as keyboard shortcut in the mixer board. Replacing & by && allows us to show server-names correctly. Fixes: jamulussoftware#1886
ann0see
force-pushed
the
bugfix/1886-ReplaceAmpersand
branch
from
c7e884a to
9eb0855
Compare
pljones
approved these changes
Jun 27, 2021
softins
approved these changes
Jun 28, 2021
|
Works ok on Mac |
|
CHANGELOG: Bug: Ampersand in server name now shows correctly in the mixer board |
|
@HughePaul could you please verify that this PR fixed your problem? You can download the binary from the checks tab above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This is a bug-fix
Context: Fixes an issue?
If a server-name contained '&' this was interpreted as keyboard shortcut in the mixer board.
Replacing & by && allows us to show server-names correctly.
Fixes: #1886
Does this change need documentation? What needs to be documented and how?
Only an entry in the change log.
Status of this Pull Request
Working implementation. Ready for review
What is missing until this pull request can be merged?
Ready for review:
Needes: two approvals (based on tests on macOS and Windows)
Checklist