Android - close buttons (chat and settings) - #1763 fix #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Jun 14, 2021
pljones
reviewed
Jun 14, 2021
pljones
changed the title
pljones
approved these changes
Jun 15, 2021
|
I don’t have an Android device at hand at the moment, but can anyone test it? |
|
Loaded up, connected, got feedback that didn't get detected, disconnected, checked in settings and feedback detection was enabled, closed settings using the menu. Checked Chat - closed using the menu okay. (Android Moto G9 Power - the vertical sizing does need to be addressed still, my screen was too short.) |
|
CHANGELOG: Add close button on Android to enhance UX |
|
Great thanks team :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1763: add close button for dialogs in Android.