-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IT Update for 3.7.0 #1112
IT Update for 3.7.0 #1112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just added the official checklist here. There's also another file (.qm) which is empty, but I think that's no problem
- Listed in the Contributors UI
Line 502 in 04bba26
"<p>Giuseppe Sapienza (<a href=\"https://github.com/dzpex\">dzpex</a>)</p>" - Changes look consistent
- No untranslated strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Missed a typo
</message> | ||
<message> | ||
<location filename="../../clientsettingsdlg.cpp" line="178"/> | ||
<source>This opens the driver settings of your sound card. Some drivers allow you to change buffer settings, others like ASIO4ALL let you choose input or outputs of your device(s). More information can be found on jamulus.io.</source> | ||
<translation type="unfinished"></translation> | ||
<translation>Aprirà il software di gestione della scheda audio. I driver danno la possibilità di modificare i valori del buffer delay e in alcuni casi, come con gli ASIO$ALL di scegliere gli input e gli output da usare. Altre informazioni sono disponibili sul sito jamulus.io.</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. sorry: missed this line you typed ASIO$ALL, but I think it should be ASIO4ALL here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's a mistake... i resend the correct file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will approve once the comment by @ann0see is addressed. :)
By the way @dzpex you can now open a PR with your changes to the translate3_7_0 branch on the website repo. |
Thanks for your job!! |
Thanks for your job too! BTW: your last commit has an unfinished attribute. Could you please remove it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.