Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dutch translation for 3.7.0 (see #1086) #1110

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Update Dutch translation for 3.7.0 (see #1086) #1110

merged 3 commits into from
Feb 25, 2021

Conversation

jerogee
Copy link
Contributor

@jerogee jerogee commented Feb 25, 2021

With improved consistency. Also covers #1069 and #1070.

@softins softins added this to the Release 3.7.0 milestone Feb 25, 2021
@ann0see
Copy link
Member

ann0see commented Feb 25, 2021

I'm sorry, but I don't see any changes here? Did you commit the correct file?

ann0see
ann0see reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See my comment.

@ann0see ann0see mentioned this pull request Feb 25, 2021
Closed
39 tasks
@ann0see
Copy link
Member

ann0see commented Feb 25, 2021 •
edited
Loading

Adding the official checklist here too.

  • Listed in the Contributors UI

    jamulus/src/util.cpp

    Line 500 in 04bba26

    "<p>Jeroen Geertzen (<a href=\"https://github.com/jerogee\">jerogee</a>)</p>"
  • Changes look consistent (see comments above)
  • No untranslated strings

hoffie
hoffie reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. @ann0see's comment should to be checked before merge.

ann0see
ann0see approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the change.

@ann0see ann0see requested a review from hoffie February 25, 2021 20:52
hoffie
hoffie approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ann0see ann0see merged commit 00b7f4e into jamulussoftware:master Feb 25, 2021
@jerogee jerogee deleted the update/dutch-translation-3.7.0 branch February 25, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffie hoffie hoffie approved these changes

@ann0see ann0see ann0see approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tracking
Status: Triage
Milestone
Release 3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jerogee @ann0see @hoffie @softins