Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chatlog on the client #276

Closed
Snayler opened this issue May 24, 2020 · 14 comments
Closed

Create chatlog on the client #276

Snayler opened this issue May 24, 2020 · 14 comments
Labels
feature request Feature request

Comments

@Snayler
Copy link
Contributor

Snayler commented May 24, 2020

I was thinking it could be useful to create a chatlog file on the server (and maybe on the client) so that people can keep a log of what was said in chat.

Sometimes we share links with each other and it would be nice to be able to go back and consult these links at a later time, without fear of closing Jamulus and loosing the chat log. One example use-case, a covers band where people share youtube links to songs for everyone to study for the next rehearsal. Sure one could just copy the chatlog during the session and paste it in some file, but having the server/client do this automatically would be a plus.

@Snayler Snayler changed the title Create chatlog on the server Create chatlog on the server/client May 24, 2020
@corrados
Copy link
Contributor

I would not store any chat on the server. If a log shall be implemented, it should be done on the client side. Because if I am in a session with another musician and I want to write something to him, I do not want others to see my text if any other connects to that same server after we both have left.

@corrados corrados added the feature request Feature request label May 24, 2020
@Snayler
Copy link
Contributor Author

Snayler commented May 24, 2020

Ok, that makes sense from a privacy point of view. Yes, only client side during a session could work.

@corrados corrados changed the title Create chatlog on the server/client Create chatlog on the client May 26, 2020
@corrados
Copy link
Contributor

I just changed the title to reflect our discussion.

@Snayler
Copy link
Contributor Author

Snayler commented May 26, 2020

I do not want others to see my text if any other connects to that same server after we both have left.

I re-read this and realized something. My initial idea was not to have a "persistent" chat, where messages from an older session could be read when someone connected after. The idea was for the server to keep a text log file.

As for privacy concerns, I also realized that's gone out the window as soon as recording was implemented. We never know if a server is recording, in which case our voice conversations can be recorded. Jamulus as it is right now and on public servers, should not be regarded as a privacy oriented means of communication, from a client point of view.

@corrados
Copy link
Contributor

Ok, but for whoom is that text log file for? For the server operator to find out if someone has texted something illegal?

@corrados
Copy link
Contributor

We never know if a server is recording

I already thougt about this issue. We may implement an indicator that recording is enabled. Then every client can clearly see whats going on and can disconnect from that server if he does not want his audio to be recorded.

@Snayler
Copy link
Contributor Author

Snayler commented May 26, 2020

Ok, but for whoom is that text log file for? For the server operator to find out if someone has texted something illegal?

Yes, I want to police my own server /joke. I was thinking more in private server terms. Someone forgets to turn on the chat log during rehearsal, can ask server operator to send him the log. But now that I gave more than 1 second thought on this, the log can be sent from another member connected at the time. And people might want to text stuff not meant for the server operator to know, so privacy outweighs convenience.

I already thougt about this issue. We may implement an indicator that recording is enabled. Then every client can clearly see whats going on and can disconnect from that server if he does not want his audio to be recorded.

I was about to open an issue to request that feature. That would effectively solve these privacy concerns with server recordings, and give users the choice.

@corrados
Copy link
Contributor

I was about to open an issue to request that feature.

Yes, go ahead. It's a useful feature.

@gilgongo
Copy link
Member

@Snayler Are you OK with this? Shall we close the issue?

@Snayler Snayler closed this as completed Dec 15, 2020
@corrados
Copy link
Contributor

Why is this closed? The feature is not yet implemented.

@Snayler Snayler reopened this Dec 15, 2020
@Snayler
Copy link
Contributor Author

Snayler commented Dec 15, 2020

Sorry, I thought it was

@gilgongo
Copy link
Member

Oh OK. I assumed it had morphed into a server recording indicator.

I would think that a server-side chat log will meet some stiff opposition from privacy advocates, but we shall see :-)

@corrados
Copy link
Contributor

@Snayler I have implemented the feature and we are discussing it in the pull request #844. Since you originated the feature request, maybe you want to contribute to that discussion.

@ann0see
Copy link
Member

ann0see commented Feb 16, 2021

I'll close this for now since the PR was closed too.

@ann0see ann0see closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

4 participants