Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ASIO SDK usage #2417

Closed
14 of 15 tasks
hoffie opened this issue Feb 20, 2022 · 90 comments
Closed
14 of 15 tasks

Clarify ASIO SDK usage #2417

hoffie opened this issue Feb 20, 2022 · 90 comments
Milestone

Comments

@hoffie
Copy link
Member

hoffie commented Feb 20, 2022

It seems to be non-obvious how the ASIO SDK and its license integrates with Jamulus. We should do everything to make the situation more clear.

References:
See PDF in the SDK zip.

I'm currently don't plan to work on this myself, but I do think that we should move this forward for the next release and have added it to 3.9.0 therefore.

@hoffie hoffie added this to the Release 3.9.0 milestone Feb 20, 2022
@gilgongo
Copy link
Member

The approved wording for the copyright statement is: ”ASIO is a trademark and software of Steinberg Media Technologies GmbH”

@gilgongo

This comment was marked as outdated.

@gilgongo

This comment was marked as outdated.

@hoffie

This comment was marked as outdated.

@gilgongo

This comment was marked as outdated.

@hoffie

This comment was marked as outdated.

@gilgongo

This comment was marked as outdated.

@ann0see ann0see mentioned this issue Feb 26, 2022
5 tasks
@ann0see

This comment was marked as outdated.

@gilgongo

This comment was marked as outdated.

@hoffie

This comment was marked as resolved.

@gilgongo

This comment was marked as outdated.

@gilgongo
Copy link
Member

gilgongo commented Feb 28, 2022

OK so as further discussed on Discord just now, if we assume that the only issue is the distribution of the Windows client binary being the object of Steinberg's terms, then we don't have to worry about the source (which contains none of their code). Ergo, we don't need an addendum to the GPL. This assumes that because Steinberg don't mention source or binaries, we can interpret their rights granted for us to create "an application that can host ASIO device drivers" with the SDK as applying only to the binary, and the distribution (not use) of it.

I've updated the ticket with the actions we need to take, and will mark the above discussion items as "outdated" or "resolved".

@gilgongo
Copy link
Member

gilgongo commented Mar 1, 2022

I'm happy to sign the agreement once we have the stuff ready to publish on the website at least (app stuff can maybe wait a bit). In the box that says "Company or Organization" I assume it's just "Jamulus" (with me named as the representative).

There's also a "technical representative" needed. Any volunteers? I think they imply we have to print out the doc, sign it, then scan it and email the image to them.

@pljones
Copy link
Collaborator

pljones commented Mar 1, 2022

I assume it's just "Jamulus"

Given the Github account is "jamulussoftware", I use "Jamulus Software" in full - that way it more clearly covers every usage under that account, rather than perhaps jamulussoftware/jamulus.

"technical representative"

Well, you know the set of qualifying volunteers. I'm happy to have my name there. Does it need my signature, too?

(Maybe photo your signature, cut-n-paste in an appropriate editor, print to PDF - no paper involved...)

hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
Also ensure (for license reasons) that we don't include ASIO headers on
JACK builds.

Related: jamulussoftware#2417
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
Also ensure (for license reasons) that we don't include ASIO headers on
JACK builds.

Related: jamulussoftware#2417
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 1, 2022
@pgScorpio
Copy link
Contributor

There's also a "technical representative" needed. Any volunteers?

If no one of the main contributers volunteer, I will.

hoffie added a commit to hoffie/jamulus that referenced this issue Mar 2, 2022
Also ensure (for license reasons) that we don't include ASIO headers on
JACK builds.

Related: jamulussoftware#2417
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 2, 2022
hoffie added a commit to hoffie/jamulus that referenced this issue Mar 2, 2022
@pgScorpio

This comment was marked as resolved.

@gilgongo

This comment was marked as resolved.

@henkdegroot

This comment was marked as resolved.

@henkdegroot

This comment was marked as resolved.

@pljones
Copy link
Collaborator

pljones commented May 22, 2022

#2605 is done ready, pending approve and merge.

Can someone update here on what's left? Are changes in progress where needed?

@gilgongo
Copy link
Member

gilgongo commented May 22, 2022

I think think the checklist is up to date (assuming we're OK with the installer screen )

@hoffie

This comment was marked as resolved.

@gilgongo

This comment was marked as resolved.

@hoffie

This comment was marked as resolved.

@henkdegroot

This comment was marked as resolved.

@pljones

This comment was marked as resolved.

@gilgongo

This comment was marked as resolved.

@gilgongo
Copy link
Member

gilgongo commented Jun 3, 2022

We are now in compliance with what Steinberg want (once the next release goes live that is), so all that remains is to sign their agreement. We can presumably produce the nosound non-ASIO Windows server later as that's more about us than them.

I'll ping the relevant people for their signatures offline.

@ann0see
Copy link
Member

ann0see commented Jun 14, 2022

Ok. The nosound build could also just be the JACK build, so I‘d say for now that’s the way to go without ASIO.

@pljones
Copy link
Collaborator

pljones commented Jun 18, 2022

@gilgongo Any update on the admin side?

Also, can we open a separate issue to track any further work and close this one as complete for 3.9.0?

@ann0see
Copy link
Member

ann0see commented Jun 18, 2022

Ah yes, and please do not hide the comments on this issue to make them visible without the need of being logged in. Especially for this kind of stuff, we should be transparent.

@pljones
Copy link
Collaborator

pljones commented Jun 25, 2022

Just to add:

  • Make a Windows server download using "nosound" which doesn't touch ASIO SDK

This is now called "serveronly" to make it clearer what it's for. The "no-ASIO" Windows client is the JACK one, as @ann0see says. I think this action can be marked done (i.e. I'm assuming the aim was for a non-ASIO Windows offering, not a server-only build).

@pljones
Copy link
Collaborator

pljones commented Jun 25, 2022

@hoffie

  • Sign the agreement and send it to Steinberg to cover jamulus.io's distribution of ASIO-enabled Windows binaries (we can't cover other usages, sadly)

From what I saw, I'd done my bit -- is there anything left from our side to do here?

@hoffie
Copy link
Member Author

hoffie commented Jun 27, 2022

I think all code-wise stuff is done. If someone (@gilgongo? @pljones?) can confirm that the agreement has been signed and sent, then we can check that part and close the issue.
If we don't know the current state (I don't), we could open a new issue for tracking that part and close this one as done (which was mostly about tracking and the code).

@pljones
Copy link
Collaborator

pljones commented Jun 30, 2022

Looks like we're stuck on this until we here from @gilgongo again.

@gilgongo
Copy link
Member

gilgongo commented Jul 2, 2022

Oops sorry - I was just thinking that we can only sign and send when we've released the changes.

@hoffie
Copy link
Member Author

hoffie commented Jul 2, 2022

Ah, good point. If they check carefully (or at all), it might make sense to do it that way.
Maybe close this one as done as part of 3.9.0 and open a new issue for sending the agreement post-3.9.0?

@gilgongo
Copy link
Member

gilgongo commented Jul 2, 2022

OK let's do that then - closing this as done and I'll prep an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants