Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #336

Closed
victor-moreno opened this issue Jan 26, 2022 · 0 comments · Fixed by #337
Closed

Translations #336

victor-moreno opened this issue Jan 26, 2022 · 0 comments · Fixed by #337

Comments

@victor-moreno
Copy link
Contributor

Hi,
I found a place in conttables.R where translation is needed but was not captured because the string is in a variable (self$options$compare), not literal.
It is the row/column label of the footnote of the odds table, lines 531, 532

                    odds$addFootnote(rowNo=othRowNo, 'v[dp]', paste(self$options$compare, .('compared')))
                    odds$addFootnote(rowNo=othRowNo, 'v[rr]', paste(self$options$compare, .('compared')))

Probably the string can be captured for translation with something like

                    rows_or_columns <- ifelse (self$options$compare == "rows", "rows", "colums")
                    odds$addFootnote(rowNo=othRowNo, 'v[dp]', paste(rows_or_columns, .('compared')))
                    odds$addFootnote(rowNo=othRowNo, 'v[rr]', paste(rows_or_columns, .('compared')))

jonathon-love added a commit that referenced this issue Jan 27, 2022
jonathon-love added a commit that referenced this issue Jan 27, 2022
jonathon-love added a commit that referenced this issue Feb 4, 2022
jonathon-love added a commit that referenced this issue Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant