Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: FlowRouter Support #7

Open
boustanihani opened this issue Apr 21, 2015 · 16 comments
Open

Question: FlowRouter Support #7

boustanihani opened this issue Apr 21, 2015 · 16 comments
Labels

Comments

@boustanihani
Copy link

Does this package also work with FlowRouter ?

@jamielob
Copy link
Owner

Hi @boustanihani, I've not used FlowRouter before - do you know if it uses the Meteor _uihooks?

@boustanihani
Copy link
Author

Sorry I never used Meteor _uihooks

@jamielob
Copy link
Owner

Have you tried using the transitions package and FlowRouter together to see if it works?

@boustanihani
Copy link
Author

Not yet, but if I do I'll let you know.

@jamielob
Copy link
Owner

Thanks! I'll be interested to know.

@jamielob jamielob assigned jamielob and unassigned jamielob Apr 21, 2015
@boustanihani
Copy link
Author

👍

@jonlachlan
Copy link

I just tried using this with Flow-Router, it works perfectly well!

@jamielob
Copy link
Owner

jamielob commented Jun 7, 2015

Great! Thank you for letting us know. If you have time could you put together a quick PR for the Readme?

@jamielob
Copy link
Owner

jamielob commented Aug 2, 2015

Hey @jonlachlan - Just testing FlowRouter out and couldn't get it to work with the transitions yet. Did you have to do anything special to get it working?

@jonlachlan
Copy link

@jamielob sry for not getting back with PR for docs. Pretty sure I used flow-layout (now called blaze-layout) in conjunction with flow-router.

@jamielob
Copy link
Owner

jamielob commented Aug 4, 2015

Ok thanks.

@skoch
Copy link

skoch commented Apr 13, 2016

Has this question been properly answered/proven? I haven't been able to use FlowRouter/BlazeLayout to get the transitions working.

@jamielob
Copy link
Owner

@skoch - Let me put together a demo repo for FlowRouter usage.

@skoch
Copy link

skoch commented Apr 13, 2016

I just got your demo working locally and was going to work backwards from there to see if I can't get that working with FlowRouter/BlazeLayout.

However, a demo repo would be welcome! Thanks.

@jamielob
Copy link
Owner

@skoch: Wow a lot has changed since I wrote this package!!! This could really do with a version 3 update. Not sure if I have time to do that right now though.

The biggest issue I can see right now is related to how BlazeLayout renders into a dive is conflicting with how this package implements the UI hooks. Perhaps @jonlachlan can share how he got it working.

@skoch
Copy link

skoch commented Apr 14, 2016

@jamielob: Thanks for looking into this. If/when you do have time please let me know. (I couldn't reverse engineer your code and don't know enough about the intricacies of Meteor just yet to attempt building something like this. 😞 )

If @jonlachlan has any insight, fabulous. Otherwise, till next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants