Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

SpatialOS SDK 13.6 Upgrade #73

Merged
merged 4 commits into from
Feb 21, 2019
Merged

SpatialOS SDK 13.6 Upgrade #73

merged 4 commits into from
Feb 21, 2019

Conversation

jamiebrynes7
Copy link
Owner

@jamiebrynes7 jamiebrynes7 commented Feb 20, 2019

This PR upgrades the underlying SDK to 13.6.0. This has the following changes:

  • Bindings updated (lots of u32 changed to i32, need to look into this).
  • KCP is now stable and has some small changes to the configuration
  • The structure of some of the dev auth flow structs has changed.
  • Removed the need for schema file globbing

Fixes #69

@@ -63,14 +63,6 @@ pub fn run_codegen(config: &Config) -> Result<(), Box<dyn std::error::Error>> {
command.arg(&arg);
}

// Add all schema files in the std lib.
add_schemas(&std_lib_path.join("improbable"), &mut command);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jamiebrynes7
Copy link
Owner Author

Did some digging why the u32 and i32 change. According to rust-lang/rust-bindgen#1096 (comment) it looks like its due to Clang differences.

In any case, it doesn't make a difference here

@jamiebrynes7 jamiebrynes7 merged commit 6483ef7 into master Feb 21, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/13.6-upgrade branch February 21, 2019 20:37
@jamiebrynes7 jamiebrynes7 mentioned this pull request Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants