Skip to content

Commit

Permalink
Merge pull request #2 from mizutani256/fix-coverage-criteria
Browse files Browse the repository at this point in the history
Use non-strict comparison in coverage criteria
  • Loading branch information
jamie-pate authored Apr 28, 2023
2 parents 8cae469 + c23b298 commit e03df3b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions addons/coverage/Coverage.gd
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,8 @@ func coverage_passing() -> bool:
if _coverage_target_file < INF:
for script in coverage_collectors:
var script_percent = coverage_collectors[script].coverage_percent()
all_files_passing = all_files_passing && script_percent > _coverage_target_file
return coverage_percent() > _coverage_target_total && all_files_passing
all_files_passing = all_files_passing && script_percent >= _coverage_target_file
return coverage_percent() >= _coverage_target_total && all_files_passing

# see ScriptCoverage.Verbosity for verbosity levels
func script_coverage(verbosity := 0):
Expand Down

0 comments on commit e03df3b

Please sign in to comment.