Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to ArgumentParser #1

Closed
macmule opened this issue Jun 29, 2020 · 3 comments · Fixed by #20
Closed

Move to ArgumentParser #1

macmule opened this issue Jun 29, 2020 · 3 comments · Fixed by #20
Assignees
@davidnorris78
Labels
help wanted Extra attention is needed

Comments

@macmule
Copy link
Member

macmule commented Jun 29, 2020 •
edited
Loading

All is working, but now there is a standard parser to move to:

https://swift.org/blog/argument-parser/
@macmule
Copy link
Member Author

macmule commented Jun 29, 2020

Notifier - Move to ArgumentParser

@macmule macmule transferred this issue from another repository Jul 7, 2020
@macmule macmule changed the title Move to ArgumentParser Notifier - Move to ArgumentParser Jul 7, 2020
@macmule macmule transferred this issue from another repository Jul 7, 2020
@macmule macmule added the help wanted Extra attention is needed label Jul 7, 2020
@macmule macmule changed the title Notifier - Move to ArgumentParser Move to ArgumentParser Jul 7, 2020
@macmule macmule self-assigned this May 19, 2021
@macmule macmule added this to the 2.3 milestone May 4, 2022
@macmule macmule assigned davidnorris78 and unassigned macmule May 4, 2022
@macmule
Copy link
Member Author

macmule commented May 11, 2022

@davidnorris78 loving the work in https://github.com/dataJAR/Notifier/tree/ArgumentParser-migration

Can you amend to remove the output when a command is sent?

The following output, for example:

argParser(_message: Optional("message"), _messageaction: nil, _type: Optional("banner"), _sound: nil, _subtitle: nil, _title: nil, _messagebutton: nil, _messagebuttonaction: nil, _remove: nil, _verbose: nil)

This was referenced May 26, 2022
Closed
Merged
macmule added a commit that referenced this issue May 26, 2022
@macmule
Manually brought over changes from ArgumentParser-migration branch
1c235c2 
Resolves #17 and #1
@macmule macmule reopened this Jun 27, 2022
@macmule
Copy link
Member Author

macmule commented Jun 27, 2022

Can --verbose be amended to not need a value passed, like --help?

@macmule macmule mentioned this issue Apr 21, 2023
Merged
@macmule macmule closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidnorris78 davidnorris78

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Argument parser migration jamf/Notifier
2 participants
@macmule @davidnorris78