Skip to content

Commit

Permalink
Remove obsolete comment from observatory.py.
Browse files Browse the repository at this point in the history
Add TODO about non-bisque mounts, which assumes all are serial.
  • Loading branch information
jamessynge committed Dec 23, 2017
1 parent 06a9164 commit 61d5198
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions pocs/observatory.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,12 +495,6 @@ def _create_mount(self, mount_info=None):
This method ensures that the proper mount type is loaded.
Note:
This does not actually make a serial connection to the mount. To do so,
call the 'mount.connect()' explicitly.
TODO(jamessynge): Discuss this claim with Wilfred. SerialData automatically
opens the connection, but doesn't start using it.
Args:
mount_info (dict): Configuration items for the mount.
Expand All @@ -521,6 +515,10 @@ def _create_mount(self, mount_info=None):
model = mount_info.get('brand')
driver = mount_info.get('driver')

# TODO(jamessynge): We should move the driver specific validation into the driver
# module (e.g. module.create_mount_from_config). This means we have to adjust the
# definition of this method to return a validated but not fully initialized mount
# driver.
if model != 'bisque':
port = mount_info.get('port')
if port is None or len(glob(port)) == 0:
Expand Down

0 comments on commit 61d5198

Please sign in to comment.