This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21
The problem
The old implementation propagated changes through Context. This was problematic in situations where there were a lot of focused nodes: any change to the focus tree would rerender every subscribed component.
I was observing noticeable drops in performance due to this problem.
This solution
In this solution, Context never causes a rerender, because the Context values are always static.
Instead, localized state causes a render. This state is kept in sync using
focusTree.subscribe()
. To ensure that the fewest number of things render at a time, a comparison check is utilized in the subscribe callback to see if state should be synchronized.Additional work
It would probably be worthwhile to refactor the
Focusable
in a more substantial way. Perhaps I'll do that when I work on #25Alternative solutions
Context selectors is an alternative solution, but as of the time of writing they are only an RFC.