Fix Issue #42 #59
Merged
Fix Issue #42 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has for goal to fix the issue #42
Having looked at this stackoverflow post it seems that setting .Enabled = false on a UIRefreshControl does not do anything, because it's actually the UIScrollView wrapping the UIRefreshControl that decides whether or not the control should be displayed.
Following that logic the solution seems to simply remove the UIRefreshControl from its Superview when the property IsPullToRefreshEnabled is set to false, and to try to insert it again when IsPullToRefreshEnabled is set to true.
Also updated the ListViewPage sample, to demonstrate the working databinding on the IsPullToRefreshEnabled property.
Also fixed a typo in ListViewPage.cs refreshView.SetBinding(PullToRefreshLayout.IsRefreshingProperty**, ,** new Binding("IsBusy", BindingMode.OneWay));
that was preventing the sample project from building.
Note: Changes to the .csproj file are automatically applied by Visual Studio for mac