make accessing process.StartTime best-effort

jamesmanning · Jul 9, 2018 · 7507db4 · 7507db4
1 parent c63ae3a
commit 7507db4
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/src/RunProcessAsTask/ProcessEx.cs b/src/RunProcessAsTask/ProcessEx.cs
@@ -8,14 +8,6 @@ namespace RunProcessAsTask
 {
     public static partial class ProcessEx
     {
-        public static Task<ProcessResults> RunAsync(ProcessStartInfo processStartInfo) 
-            => RunAsync(processStartInfo, CancellationToken.None);
-
-        public static async Task<ProcessResults> RunAsync(ProcessStartInfo processStartInfo, CancellationToken cancellationToken)
-        {
-            return await RunAsync(processStartInfo, new List<string>(), new List<string>(), cancellationToken);
-        }
-
         public static async Task<ProcessResults> RunAsync(ProcessStartInfo processStartInfo, List<string> standardOutput, List<string> standardError, CancellationToken cancellationToken)
         {
             // force some settings in the start info so we can capture the output
@@ -73,12 +65,27 @@ await standardErrorResults.Task.ConfigureAwait(false)
                 })) {
                 cancellationToken.ThrowIfCancellationRequested();
 
+                var startTime = DateTime.Now;
                 if (process.Start() == false)
+                {
                     tcs.TrySetException(new InvalidOperationException("Failed to start process"));
-                processStartTime.SetResult(process.StartTime);
+                }
+                else
+                {
+                    try
+                    {
+                        startTime = process.StartTime;
+                    }
+                    catch (Exception)
+                    {
+                        // best effort to try and get a more accurate start time, but if we fail to access StartTime
+                        // (for instance, process has already existed), we still have a valid value to use.
+                    }
+                    processStartTime.SetResult(startTime);
 
-                process.BeginOutputReadLine();
-                process.BeginErrorReadLine();
+                    process.BeginOutputReadLine();
+                    process.BeginErrorReadLine();
+                }
 
                 return await tcs.Task.ConfigureAwait(false);
             }

diff --git a/src/RunProcessAsTask/ProcessEx.overloads.cs b/src/RunProcessAsTask/ProcessEx.overloads.cs
@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace RunProcessAsTask
@@ -15,5 +16,11 @@ public static Task<ProcessResults> RunAsync(string fileName)
 
         public static Task<ProcessResults> RunAsync(string fileName, string arguments)
             => RunAsync(new ProcessStartInfo(fileName, arguments));
+
+        public static Task<ProcessResults> RunAsync(ProcessStartInfo processStartInfo)
+            => RunAsync(processStartInfo, CancellationToken.None);
+
+        public static Task<ProcessResults> RunAsync(ProcessStartInfo processStartInfo, CancellationToken cancellationToken) =>
+            RunAsync(processStartInfo, new List<string>(), new List<string>(), cancellationToken);
     }
 }