Skip to content

Commit

Permalink
Remove TODOs and code in application launcher cluster (project-chip#1…
Browse files Browse the repository at this point in the history
…4975)

* Remove todo and code in application launcher cluster

* Updated per comment
  • Loading branch information
lazarkov authored and fuxingguo16 committed Apr 26, 2022
1 parent 85fc1dd commit 2388f93
Showing 1 changed file with 1 addition and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,7 @@ CHIP_ERROR Delegate::HandleGetCurrentApp(app::AttributeValueEncoder & aEncoder)
}
#endif // CHIP_DEVICE_CONFIG_APP_PLATFORM_ENABLED

// TODO: change to return null once 13606 is fixed
ApplicationEPType currentApp;
currentApp.application.catalogVendorId = 123;
currentApp.application.applicationId = CharSpan("applicationId", strlen("applicationId"));
currentApp.endpoint = Optional<EndpointId>::Missing();
return aEncoder.Encode(currentApp);
return aEncoder.EncodeNull();
}

} // namespace ApplicationLauncher
Expand Down Expand Up @@ -212,14 +207,6 @@ bool emberAfApplicationLauncherClusterLaunchAppRequestCallback(app::CommandHandl
app::CommandResponseHelper<LauncherResponseType> responder(command, commandPath);

std::string appId(application.applicationId.data(), application.applicationId.size());

if (appId.length() == 0 && data.HasValue())
{
// chip-tool can't send structs from command line so treat data value as appid if appid is blank
// TODO: fix this once chip-tool support sending structs from command line
ChipLogError(Zcl, "ApplicationLauncher blank content id, taking data as appid");
appId = std::string((char *) data.Value().data(), data.Value().size());
}
CatalogVendorApp vendorApp(application.catalogVendorId, appId.c_str());

Delegate * delegate = GetDelegate(endpoint);
Expand Down

0 comments on commit 2388f93

Please sign in to comment.