Ember 1.13 and 2.0 support #227
Conversation
|
@mixonic thanks for your work on |
| } | ||
|
|
||
| if (Helper != null) { | ||
| instance.registry.register('helper:t', Helper); |
There was a problem hiding this comment.
Despite this, I get a "helper t not found" error message whenever I try to use it.
There was a problem hiding this comment.
Correct. Robert is going to land emberjs/rfcs#58 into 1.13 which will give you {{t without any explicit registration step.
There was a problem hiding this comment.
Ah. I was basing this off of https://github.com/emberjs/ember.js/pull/11278/files#diff-5d4704d516d9bedb9605e499dc0a88d8R122
I guess once dashless-autolookup lands I'll want a single app/helpers/t.js that exports either legacyHelper or Helper, depending on the presence of Ember.Helper. That'll be easy :)
|
Awesome. The dashless stuff should land soon as well. /cc @rwjblue On June 8, 2015 7:13:09 PM James Alexander Rosen [email protected]
|
|
Though this is meant to work with 1.13 (currently beta), there isn't a 1.13 beta that includes emberjs/ember.js#11278 ( The current problem I'm having is that Some relevant links: |
Previously, we were setting the locale by navigating to
`/in/:locale`. Unfortunately, that's not a very good test of the
`{{t}}` helper because it causes the whole template to be
rerendered. Instead, we use an `{{action}}` to trigger the locale
change and ensure that the *same* template gets updated.
|
After much debugging help from @mixonic, it seems to be a problem with using
|
|
@jamesarosen emberjs/ember.js#11445 contains the fix. A merge today seems likely, and a 1.13.1 on Tuesday. |
|
The last test will be fixed by emberjs/ember.js#11445 |
|
emberjs/ember.js#11445 has been merged, and is in both beta and release channels. Could you test, and confirm the release channel fixes the remaining failures here? |
1. Starting work on support for Ember 1.13. Glimmer breaks the old
helper and adds a new `Ember.Helper` with more of the power we
need.
2. v1.13 introduces a new `Ember.Service` that should
be the parent of the `service:i18n`.
3. Ember 2.0 removes `Ember.EnumerableUtils`, instead assuming
all supported browsers supply the ES5 enumerable methods.
|
Just a heads up: I think this branch breaks the bound |
|
@josepjaume have you tested with a version of Ember since emberjs/ember.js#11445 was merged? You can see the difference between build 415.4 and build 425.4 @rwjblue tests look great! Thanks :) |
|
Oh, I see! Does this mean there's a |
|
BTW: Thanks for the good work 👍 |
I'm told it'll be Tuesday. |
|
Confirmed it's working by using the {
"dependencies": {
"ember": "components/ember#release"
},
"resolutions": {
"ember": "release"
}
} |
Starting work on support for Ember 1.13. Glimmer breaks the old helper and adds a new
Ember.Helperwith more of the power we need.As of this commit, the beta build is still breaking because there's something wrong with the helper registration.