Redux #183

tomitm · 2016-05-07T21:46:35Z

Notable changes:

Migration to main process
- Proxy, UrlMapper, menu setup, and browser detection were moved into main process; too much was going on in the renderer, which actually slowed down request loads quite a bit
- Goal is to keep most things out of the renderer and prefer to do work in main (especially if it requires remote), unless it's UI-related
- Moved src/electron-app.js to src/main/index.js
  - There's actually no need to run main process code through babel/browserify (except for using require instead of import), since it's a node environment that supports ES6, but that's a change to be made later
React Router replaces windowFactory
- TitleBar and Footer are extracted out of MainContent into an App container, which RR controls the children of
- Home/Welcome split out of MainContent so the user isn't contained to a single browser session, and can launch as many browsers as they want. URL mappings are also shown the same way instead of the original modal
- src/containers contains top-level route containers, leaving the smaller components that make up the containers to the original src/component
- TitleBar uses Material-ish tab styling and shows which tab is active. Requests also have an empty state now
  - This should make it really flexible to add more features and views, such as blocking rules, options, etc.
Redux
- index.js is no longer the kitchen sink! Use redux connect to allow a component to use the redux store - dispatch actions for mutations, and make use of selectors kept in src/reducers to read store data
  - The benefits of using actions and selectors are it makes it easy to understand what your app does by having all actions in one place, and by using selectors, you can make changes to the store shape without having to worry about the components. This leaves components to simply display the data that's given to them and delegate user actions to redux
- MainContent is now RequestsContainer and no longer maintains which request is active or has a context menu (that's in Redux now)
- Since proxy/urlMapper are in the main process, their states are synced with Redux over IPC
  - All changes should be dispatched through actions, and middleware will send them over IPC to main
  - If proxy/urlMapper have changes, they dispatch a SYNC action over IPC, which a reducer will apply to the state. This allows components to just read their states via redux's connect and not worry about how that data gets there
  - Note that to avoid excessive GC, request sync doesn't send full responses. When a request is set as active, the full response is grabbed at that time for only the single request. Was also going to send a minimal request as well, but I realised the list practically showed the whole request anyway, so that was moot
Misc
- Tests now run under electron's renderer
- Added a starting status for the proxy, so that the initial state isn't working in case it's not
- Raven tracks actions and sends them along with error reports as breadcrumbs

Open devtools with a redux action. Initial work on redux'ing url mappings. Split out proxy and url-mappings from index.

This means that UrlMapper is currently authoritative over redux, however in the end, redux actions should be authoritative. No longer passing anything down from the top, components connect with redux where necessary. index.js is no longer a kitchen sink!

…x actions and store for data. Give Requests component the full request *container*, not just the request. Start to deal with the circular dependency between store <> proxy/urlMapper, because both need to tell the store about updates, and the store wants to query the dbs on actions.

…to be able to manipulate them in middleware when a related action comes in, and the proxy/urlMapper need to notify the store when they have changes. Could have resolved this by adding in an event emitter or something, as long as it could be registered after the store is setup, and reemit the events between that time. Or keep it simple, and take advantage of JS semantics where setTimeout defers until the stack is cleared, well after store is setup.

…l-ish. Update titlebar/footer to disable user-select, to closer resemble an application.

…ducers.

… without worrying about consumers.

…text. Fix lint issues.

Connect uses shallow-render checks to avoid re-rendering. If it's higher up, that leads to props being passed down, and components more likely to be re-rendered. Fix Request components getting re-rendered on active/context of another request. Fix keyboard shortcut for devtools not working.

Brutal conflict resolution; long-standing branches are horrible, kids.

# Conflicts: # package.json

… over IPC. Includes a bit of a hacky workaround to make request objects serializable, since they user getters and functions.

Fix default export derp in Search and RequestDetails.

…eck). Cleanup main process logs. Set menu bar to auto-hide.

Was inconsistent with activeRequest, so that was causing some confusion.

# Conflicts: # package.json

Not much of better way to handle this. Getters on ES classes are defined as non-enumerable on the prototype. Fortunately, most request/response properties are just accessing _data, except for a handful that aren't. Also made it a bit more efficient by combining it into a single reduce pass, rather than filter then map.

Add `proxy-get-request` to fetch the full request with response (used with `SET_ACTIVE_REQUEST`). Revert changes to service/proxy, and move request sanitization into main/proxy instead. Added lodash.throttle as sync is causing the UI to attempt to update more frequently than necessary.

We can speed up the build later by not running main through babel and browserify, as it's not necessary under the node environment (would just need to change import to require).

mitchhentges · 2016-08-24T15:25:32Z

Wooh, this is a big PR. I'll CR it "soonish"

https://greenkeeper.io/

…5-6.6.0' into redux # Conflicts: # package.json

mitchhentges · 2016-08-27T01:00:56Z

.travis.yml

@@ -11,6 +11,8 @@ addons:
    packages:
    - icnsutils
    - graphicsmagick
+before_script:
+- export DISPLAY=:99.0; sh -e /etc/init.d/xvfb start || true


Comments pls. Why 99.0? Why || true at the end? if xvfb fails to start, not sure that we should still try to run tests 'n stuff

Hmm, there was a reason for the || true. Should've left a comment, my bad. I'll go poke around and see if I can find out again.

|| true was to skip OSX, since Xfvb doesn't happen on there. Buut that's definitely a bad idea in case it fails on Linux, so I've made it better. 👌

…tch. Change `UPDATE_BROWSER` to `DISABLE_BROWSER`, as that's what it's used for. Abstract `push` from `react-router` with `navigateToFoo` since it's not really clear what `push` is. Add some consistency under /containers, and make reducers vs selectors a slight bit clearer.

mitchhentges · 2016-09-05T21:13:23Z

👍, quite a few changes, and I don't grok everything. However, it's working pretty well on Linux, and it's putting James in a good direction

Weird auto merge conflict resolution between #270 and #183.

tomitm added 19 commits May 7, 2016 21:37

Initial Redux work.

8df947f

Replace window factory with React Router.

cfa88fb

Open devtools with a redux action. Initial work on redux'ing url mappings. Split out proxy and url-mappings from index.

Handle state of Requests page in redux (active, context, fitler).

6d0b0e2

Merge branch 'master' into redux

e8e6a0b

Add more unit tests for actions and reducers.

2a3221b

Fix for request change not being re-rendered.

37ac63b

Merge branch 'master' into redux

a60ac83

Merge branch 'master' into redux

8272bf8

Move state from NewMapping to redux.

b58a80e

Update titlebar styling to include active styling and be more materia…

6e90138

…l-ish. Update titlebar/footer to disable user-select, to closer resemble an application.

Cleanup redux: use shorthand for mapDispatchToProps and use combineRe…

9a1ac4e

…ducers.

Setup selectors so that state shape can be solely managed in reducers…

0ecc86d

… without worrying about consumers.

Increase icon padding in header.

9b60b26

Run mocha under electron-renderer so that tests run in the proper con…

0b21e74

…text. Fix lint issues.

Skip logging in prod.

c4ded04

Add tests for thunk actions and fix lint issues.

6de37fa

tomitm mentioned this pull request Jun 4, 2016

Start using Redux #136

Closed

tomitm added 10 commits June 4, 2016 23:07

Merge branch 'master' into redux

c439155

Maintain scroll position when list updates.

78d1adf

Merge branch 'master' into redux

c34ff31

Brutal conflict resolution; long-standing branches are horrible, kids.

Merge branch 'master' into redux

dd079d4

# Conflicts: # package.json

Move proxy and urlMapper into main process, communicate with renderer…

7f2d425

… over IPC. Includes a bit of a hacky workaround to make request objects serializable, since they user getters and functions.

Move Request connects up into Requests.

5442b03

Fix default export derp in Search and RequestDetails.

Wire up renderer->main IPC.

109f6a2

Move browser detection to main process.

811e1f1

Fix insane performance issue (bugged Request shouldComponentUpdate ch…

c2ce277

…eck). Cleanup main process logs. Set menu bar to auto-hide.

tomitm added 10 commits July 31, 2016 23:35

Fix renderer event handlers for proxy/mapper actions.

032d7a5

Fix context menu shenanigans.

587eb39

Was inconsistent with activeRequest, so that was causing some confusion.

Add Raven middleware to redux to add action breadcrumbs.

5a710ed

Fix exception when filtering.

1b32098

Update tests.

c7b0f17

Merge remote-tracking branch 'upstream/master' into redux

41d175a

# Conflicts: # package.json

On second thought, should avoid using scrollTop/etc.

de33c22

Merge remote-tracking branch 'upstream/master' into redux

40ff526

tomitm changed the title ~~[WIP] Redux~~ Redux Aug 22, 2016

tomitm added 3 commits August 22, 2016 00:41

Move menu from renderer to main process.

52e3593

Move electron-app.js to main/index.js.

25edd04

We can speed up the build later by not running main through babel and browserify, as it's not necessary under the node environment (would just need to change import to require).

Extract routes to routes.js.

befad30

greenkeeperio-bot and others added 2 commits August 24, 2016 15:30

chore(package): update babel-preset-es2015 to version 6.6.0

6aef838

https://greenkeeper.io/

Merge remote-tracking branch 'upstream/greenkeeper-babel-preset-es201…

0069ab6

…5-6.6.0' into redux # Conflicts: # package.json

mitchhentges reviewed Aug 27, 2016
View reviewed changes

tomitm added 3 commits August 27, 2016 16:01

Figuring out some xvfb/travis shenanigans again.

5a19a2d

Fix case-sensitive import.

ed07615

mitchhentges merged commit 1a57434 into james-proxy:master Sep 5, 2016

tomitm added a commit that referenced this pull request Sep 5, 2016

Fix RequestDetails not being exported correctly.

1119c36

Weird auto merge conflict resolution between #270 and #183.

tomitm deleted the redux branch May 14, 2017 04:14

tomitm added this to the 2.0 Baby milestone May 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redux #183

Redux #183

tomitm commented May 7, 2016 •

edited

Loading

mitchhentges commented Aug 24, 2016

mitchhentges Aug 27, 2016

tomitm Aug 27, 2016

tomitm Aug 27, 2016

mitchhentges commented Sep 5, 2016

Redux #183

Redux #183

Conversation

tomitm commented May 7, 2016 • edited Loading

mitchhentges commented Aug 24, 2016

mitchhentges Aug 27, 2016

Choose a reason for hiding this comment

tomitm Aug 27, 2016

Choose a reason for hiding this comment

tomitm Aug 27, 2016

Choose a reason for hiding this comment

mitchhentges commented Sep 5, 2016

tomitm commented May 7, 2016 •

edited

Loading