Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vsashidh] Issue #49 : internet explorer instance not stopping #10

Merged
merged 1 commit into from
Feb 26, 2016
Merged

[vsashidh] Issue #49 : internet explorer instance not stopping #10

merged 1 commit into from
Feb 26, 2016

Conversation

mitchhentges
Copy link
Member

I'm a little concerned about why the instance wasn't stopping properly. Note that if you run example/launch.js with IE, it shows the following:

$ node launch.js
Instance started with PID: 3168
Instance stopped with exit code: 1
Instance stopped with exit code: 0

What's with the exit code: 1 in the middle? Hmm. (That existed before this PR, it's just curious)

@mitchhentges
Copy link
Member Author

Thanks @vsashidh!

mitchhentges added a commit that referenced this pull request Feb 26, 2016
Issue #49 : internet explorer instance not stopping
@mitchhentges mitchhentges merged commit c14e680 into james-proxy:master Feb 26, 2016
@vsashidh
Copy link

Hi Mitchell,

There is a still an issue with re-spawning the ie browser after my code stops the browser. I think it might be a windows thing not allowing for terminating the process. You might want to explore that furhter.

@mitchhentges
Copy link
Member Author

Thanks!

@mitchhentges mitchhentges changed the title Issue #49 : internet explorer instance not stopping [vsashidh] Issue #49 : internet explorer instance not stopping Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants