Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Results #68

Open
arkihillel opened this issue Sep 17, 2017 · 6 comments
Open

Inconsistent Results #68

arkihillel opened this issue Sep 17, 2017 · 6 comments

Comments

@arkihillel
Copy link

Each time I run a detect I get different results.

Running the module on OS X Sierra with nodeJS 8.4.0 with a couple of external hard drives

I get from 1 to 8 results depending on the run

@mitchhentges
Copy link
Member

Are any results consistent? When you get 1 result, is it always the same one?
Thanks for the report, I'll look into this later this week

@arkihillel
Copy link
Author

arkihillel commented Sep 17, 2017 via email

@mitchhentges
Copy link
Member

Oh, there's some installations on the external drives, gotcha.

Yeah, if you can try running the module with the externals uplugged, that'd be radical. Also, just to see if there's a pattern: can you list:

Browser Location of browser (external drive/main drive) Is consistently listed/consistently unlisted/intermitten by the module

@arkihillel
Copy link
Author

I did a fresh install of High Sierra yesterday, looks like the results are a bit different now and I can't reproduce the inconsistent number of browsers detected.

After 10 runs without external volumes:
All the browsers are detected perfectly now 👍

After 10 runs with external volumes:
I consistently get Chrome, Safari, Firefox, Chromium and Opera. They are coming from different sources though:

e.g.

/Volumes/Western Digital/backup/Applications/Google Chrome.app
/Applications/Firefox.app
/Volumes/Carbon Copy/Applications/Chromium.app
/Volumes/Western Digital/backup/Applications/Safari.app
/Volumes/Carbon Copy/Applications/Opera.app
/Volumes/Western Digital/backup/Applications/Google Chrome.app
/Volumes/Carbon Copy/Applications/Firefox.app
/Volumes/Carbon Copy/Applications/Chromium.app
/Volumes/Carbon Copy/Applications/Opera.app
/Volumes/Carbon Copy/Applications/Safari.app
/Volumes/Carbon Copy/Applications/Chromium.app
/Applications/Firefox.app
/Volumes/Western Digital/backup/Applications/Safari.app
/Applications/Opera.app
/Volumes/Western Digital/backup/Applications/Google Chrome.app

I didn't go through the sources but I guess that you're only expected one instance of each supported browser which kinda makes sense if most cases but doesn't really work in this case

Providing an option to ignore external volumes would be make it work well enough for me. Although I would still deem this a bug

@mitchhentges
Copy link
Member

Ah, I understand.
How do you have these browsers installed in two different locations? Is /Applications/$BROWSER.app a symlink to /Volumnes/...? Do you have two different versions of the same browser installed at once?

@arkihillel
Copy link
Author

Not exactly, the other volumes just contain backups which happen to have (often old) versions of the same browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants