Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium config is missing #65

Closed
ashnur opened this issue Jul 8, 2017 · 1 comment
Closed

chromium config is missing #65

ashnur opened this issue Jul 8, 2017 · 1 comment
Assignees
@mitchhentges

Comments

@ashnur
Copy link

ashnur commented Jul 8, 2017

trying to use "chromium" browser, which is detected by

➜  james-browser-launcher git:(master) ✗ node example/detect.js
Available browsers:
[ { name: 'chromium',
    version: '59.0.3071.115',
    type: 'chromium',
    command: 'chromium' } ]

results in
TypeError: setups[browser.type] is not a function
@mitchhentges mitchhentges self-assigned this Jul 9, 2017
mitchhentges added a commit that referenced this issue Jul 9, 2017
@mitchhentges
Merge pull request #66 from mitchhentges/65-chromium
632a872 
Fixes #65: Properly assign setup for chromium
@mitchhentges
Copy link
Member

mitchhentges commented Jul 9, 2017 •
edited
Loading

Thanks for the report! Fixed and released in 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchhentges mitchhentges

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashnur @mitchhentges