Merge pull request #2 from mitchhentges/process-close

Use process `close`, not process `exit`, so stdout can be flushed

CHANGELOG.md

@@ -0,0 +1,19 @@
+## Upcoming Release
+
+#### Breaking changes
+`stop` event is now emitted on process `close`, not process `exit` (so that stdout can be flushed first)
+
+#### User features
+- Detect `Canary` on `OSX` (i: @caitp, r: @mitchhentges)
+- Support launching `phantomjs` on `OSX` (i: @epmatsw, r: @mitchhentges)
+- Detect `Chromium` on `OSX` (i: @rhendric, r: @mitchhentges)
+- `IE` will now response to `stop()` (i: @vsashidh, r: @mitchhentges)
+
+#### Developer features
+- None yet
+
+#### Bugfixes
+- Docs updated to describe how `james-browser-launcher` compares to other launchers (i: @mitchhentges, r: @tomitm)
+
+# 1.0.0
+- First release as `james-browser-launcher`

lib/detect.js

@@ -140,7 +140,7 @@ function checkOthers( name, callback ) {
 		callback = null;
 	} );
 
-	process.on( 'exit', function( code ) {
+	process.on( 'close', function( code ) {
 		if ( !callback ) {
 			return;
 		}

lib/instance.js

@@ -42,7 +42,7 @@ function Instance( options ) {
 	}
 
 	// trigger "stop" event when the process exits
-	this.process.on( 'exit', this.emit.bind( this, 'stop' ) );
+	this.process.on( 'close', this.emit.bind( this, 'stop' ) );
 
 	// clean-up the temp directory once the instance stops
 	if ( this.tempDir ) {
@@ -66,11 +66,11 @@ Instance.prototype.stop = function( callback ) {
 	// Opera case - it uses a launcher so we have to kill it somehow without a reference to the process
 	if ( process.platform === 'win32' && this.image ) {
 		child.exec( 'taskkill /F /IM ' + this.image )
-			.on( 'exit', this.emit.bind( this, 'stop' ) );
+			.on( 'close', this.emit.bind( this, 'stop' ) );
 		// ie case on windows machine
 	} else if ( process.platform === 'win32' && this.browserType === 'ie' ) {
 		child.exec( 'taskkill /F /IM iexplore.exe')
-			.on( 'exit', this.emit.bind( this, 'stop' ) );
+			.on( 'close', this.emit.bind( this, 'stop' ) );
 		// OSX case with "open" command
 	} else if ( this.command === 'open' ) {
 		child.exec( 'osascript -e \'tell application "' + this.processName + '" to quit\'' );