Dont generate a 404 for unknown paths #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as these could be being processed by other handlers
|
Ignore this PR for a bit. It "fixes" my issue, but it introduces a new one when none of the handlers want to upgrade the socket and it times out rather than immediately failing. Will do some more investigation. |
|
@rjp44 is this ready for review at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WS upgrade handler can't coexist with other WS servers on the same httpServer as it sets a 404 response header on any path it isn't intrested in.
If it just silently ignores and falls through then other handlers can process the upgrade if they wish to.
See also PR #5 which was somewhat related (same problem, different 404)