Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-273] Use floating points to calculate relative time #274

Merged

Conversation

jama5262
Copy link
Owner

What does this PR do?

Use floating points to calculate relative time

Issue Reference

Fixes #273
Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance change (non-breaking change such as upgrading a dependency, refactoring, or making a lint fix)
  • Documentation update
  • Breaking change (a fix or feature that would cause existing functionality to change)

Screenshots

If applicable, add screenshots to help explain your problem.

Checklist

  • Wrote additional tests, if needed
  • All tests have passed, you can find the scripts from the ./bin folder
  • I have updated the documentation accordingly, if needed.

Additional Information

@jama5262 jama5262 marked this pull request as ready for review May 14, 2024 16:26
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (bbf07ee) to head (733cb70).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          36       36           
  Lines        1611     1611           
=======================================
  Hits         1554     1554           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jama5262 jama5262 merged commit 72998c1 into master May 14, 2024
5 checks passed
@jama5262 jama5262 deleted the ISSUE-273-use-floating-point-to-calculate-relative-time branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromNow does not pluralize correctly: "1 minutes ago"
1 participant