Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle process callback #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

suruja
Copy link

@suruja suruja commented Aug 20, 2014

Hello!

I want to use your project as a node module, and I need a callback to know when processing ends. I just add a callback to your async.series call in process function.

@GoalSmashers
Copy link
Collaborator

I've never had a chance to use it programatically. Would you be able to provide a test for this feature so I can merge it?

@suruja
Copy link
Author

suruja commented Aug 25, 2014

The callback I added to async.series is used and tested in async module itself, and the assets-packager tests suite still pass with this minor change. Do you think a new test is necessary?

@jakubpawlowicz
Copy link
Owner

It would be great to have one but there is even no skeleton for non-binary tests. Let me add it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants