#145: Change JSX.Element to React.ReactNode in typings #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jakezatecky,
With advanced usage of your lib regarding icons, I also stumbled upon the issue in #145.
TypeScript understands JSX.Element when writing the components directly in line, but React.ReactNode seems to be the far more general approach, which allows for all possible components to be passed as argument, whereas JSX.Element is only objects that are returned from React.createElement.
Source: typescript-cheatsheets/react#57 (comment)
It would be great to have this PR included in the next release to fix these issues for TypeScript users.
Kind Regards,
Florian