forked from Qiskit/qiskit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Track
QuantumCircuit.global_phase
in ParameterTable
We have previously always had a split where circuit parameters used in instructions were tracked in the `ParameterTable`, but any parameters used in the global phase were not. Any method that influenced the parameters needed to separately check the global phase, and merge that information with that in the `ParameterTable`. This made it easy to forget, or easy for the handling of it to become out of sync. This commit now tracks the global phase as part of the `ParameterTable`, so this object is now the canonical source of parameter information for the circuit (outside the context of calibrations, which are handled entirely separately). The `ParameterTable` is an internal detail, and only accessible through private attributes, so is not part of the public interface.
- Loading branch information
1 parent
1c023bd
commit e446589
Showing
3 changed files
with
121 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters