Default init plugin was not properly raising when called with an in…

…valid optimization level (Qiskit#12170) (Qiskit#12175) * Raise instead of return. --- Co-authored-by: Evgenii Zheltonozhskii <[email protected]> * link * reno --------- Co-authored-by: Evgenii Zheltonozhskii <[email protected]> (cherry picked from commit e0be97c) Co-authored-by: Luciano Bello <[email protected]>
jakelishman · Apr 13, 2024 · 7591490 · 7591490
1 parent 79c5192
commit 7591490
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/qiskit/transpiler/preset_passmanagers/builtin_plugins.py b/qiskit/transpiler/preset_passmanagers/builtin_plugins.py
@@ -90,7 +90,7 @@ def pass_manager(self, pass_manager_config, optimization_level=None) -> PassMana
             init.append(OptimizeSwapBeforeMeasure())
             init.append(RemoveDiagonalGatesBeforeMeasure())
         else:
-            return TranspilerError(f"Invalid optimization level {optimization_level}")
+            raise TranspilerError(f"Invalid optimization level {optimization_level}")
         return init
 
 

diff --git a/releasenotes/notes/followup_11468-61c6181e62531796.yaml b/releasenotes/notes/followup_11468-61c6181e62531796.yaml
@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    The default ``init`` plugin was not properly raising a :class:`.TranspilerError` when called with an invalid optimization level.
diff --git a/test/python/transpiler/test_stage_plugin.py b/test/python/transpiler/test_stage_plugin.py
@@ -86,6 +86,15 @@ def test_build_pm(self):
         )
         self.assertIsInstance(pm, PassManager)
 
+    def test_init_invalid_optlevel(self):
+        """Test default init stage with invalid optimization level.
+        See: https://github.com/Qiskit/qiskit/pull/12170"""
+        plugin_manager = PassManagerStagePluginManager()
+        with self.assertRaises(TranspilerError):
+            plugin_manager.get_passmanager_stage(
+                "init", "default", PassManagerConfig(), optimization_level=4
+            )
+
 
 @ddt.ddt
 class TestBuiltinPlugins(QiskitTestCase):