Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make typing_extensions required on all Python versions
Browse files Browse the repository at this point in the history
The extent of our use of `typing_extensions` has fluctuated over time,
but we've often had a dependency on it.  This is typically not an
onerous dependency, being pure Python, and is not uncommon for other
packages.

We've often had an upper limit on the Python version for it, just for
the principle of least requirements, but this has led to a subtle bug
recently where we began using a Python 3.12 feature from it (`Unpack`)
with the requirement left at `python_version<'3.11'` from before.  This
was caught by our nightly full test suite, but for unrelated reasons,
that's not commenting correctly on issues at the moment.  This error is
quite likely to repeat; we only use the backport package for Python
versions that _aren't_ the newest, but our PR CI tests only oldest and
newest.

This commit simply lifts the upper limit on the package; the impact
should be minimal since most environments will already be installing it.
jakelishman committed Jan 4, 2024
1 parent 5eabdbe commit 660ca2d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -6,5 +6,5 @@ sympy>=1.3
dill>=0.3
python-dateutil>=2.8.0
stevedore>=3.0.0
typing-extensions; python_version<'3.11'
typing-extensions
symengine>=0.9,!=0.10.0

0 comments on commit 660ca2d

Please sign in to comment.