Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta CDI 4.1 final release #704

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Conversation

starksm64
Copy link
Contributor

@starksm64 starksm64 commented Mar 1, 2024

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
  • Specification PDF in the form of jakarta-wombat-spec-x.y.pdf
  • Specification HTML in the form of jakarta-wombat-spec-x.y.html
  • A specification page named _index.md following the template at:
    https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
  • For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable. N/A
  • For a Release Review, a summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification. The TCK users guide MUST include the instructions to run the compatible implementations used to validate the release.
    Instructions MAY be by reference.
    • Updated release record
    • Generated IP Log
    • Email to PMC
    • Start release review by emailing EMO
  • The URL of the OSSRH staging repository for the api, javadoc:
    https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/enterprise/jakarta.enterprise.cdi-api/4.1.0/
  • The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
    https://download.eclipse.org/ee4j/cdi/4.1/
  • The URL of the compatibility certification request issue:
    Weld 6.0.0.Beta1
  • Specification JavaDoc in the wombat/x.y/apidocs directory.
    If desired, an optional second PR can be created to contain just the JavaDoc in the apidocs directory.

Note: If any item does not apply, check it and mark N/A below it.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 2f025d9
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/65efed408a5dac0008b8113f
😎 Deploy Preview https://deploy-preview-704--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@starksm64
Copy link
Contributor Author

This should be ready

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Mar 3, 2024
@Emily-Jiang
Copy link
Contributor

@starksm64 I added a comment on the CCR as it needs to be executed by both Java 17 and Java 21. Once it is ready, I can start the ballot.

@starksm64
Copy link
Contributor Author

@Emily-Jiang The SE 21 runs have been added

@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Mar 5, 2024

@starksm64 I reviewed the PR and found the following issues, which need to be resolved: See here

  1. The spec doc status still shows Draft. Therefore, the license was wrong as well. You need to restage the release.
  2. On the CDI 4.1 page,
    a. you need to update the Minimum Java SE Version to Java SE 11 as currently it shows Java SE 17 or higher.
    b. At the moment, only cdi main jar was listed. Do we also need to list the lang model and cdi.el jar as well. If not, where would be listed.
    c. Do we need to say CDI 4.1 beans.xml instead of saying CDI 4.0 beans.xml.

Schemas

[XML Schema for the CDI 4.0 beans.xml deployment](https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd)
No changes currently planed for the schema

d. Under Compatible Implementations, please remove tbd.

Signed-off-by: Scott M Stark <[email protected]>
@starksm64
Copy link
Contributor Author

starksm64 commented Mar 5, 2024 via email

@Emily-Jiang
Copy link
Contributor

@starksm64 I reviewed the PR and found the following issues, which need to be resolved: See here

1. The spec doc status still shows `Draft`. Therefore, the license was wrong as well. You need to restage the release.

2. On the [CDI 4.1 page](https://deploy-preview-704--jakartaee-specifications.netlify.app/specifications/cdi/4.1/),
   a. you need to update the Minimum Java SE Version to Java SE 11 as currently it shows Java SE 17 or higher.
   b. At the moment, only cdi main jar was listed. Do we also need to list the lang model and cdi.el jar as well. If not, where would be listed.
   c. Do we need to say CDI 4.1 beans.xml instead of saying CDI 4.0 beans.xml.

Schemas

[XML Schema for the CDI 4.0 beans.xml deployment](https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd)
No changes currently planed for the schema

d. Under Compatible Implementations, please remove tbd.

@starksm64 there are more changes to be done apart from removing tbd. Please see my comments above.

Signed-off-by: Scott M Stark <[email protected]>
- Add lang-model and el-api artifact links

Signed-off-by: Scott M Stark <[email protected]>
- jakarta.enterprise.cdi-api
- jakarta.enterprise.cdi-el-api
- jakarta.enterprise.lang-model

Signed-off-by: Scott M Stark <[email protected]>
@starksm64
Copy link
Contributor Author

@Emily-Jiang There should be nothing left to do on this

@ivargrimstad ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Mar 13, 2024
@Emily-Jiang Emily-Jiang added the approved The ballot was approved by the Specification Committee label Apr 2, 2024
@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Apr 10, 2024

  • On ballot completion, the specification committee mentor:
  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to [email protected]. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team:

@Emily-Jiang Emily-Jiang merged commit 84e9004 into jakartaee:master Apr 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants