Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for the 2.2 release of interceptors #702

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

starksm64
Copy link
Contributor

@starksm64 starksm64 commented Feb 22, 2024

Draft of the Interceptors 2.2 spec update. Needs to wait on the CDI TCK for finalization.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
  • Specification PDF in the form of jakarta-wombat-spec-x.y.pdf
  • Specification HTML in the form of jakarta-wombat-spec-x.y.html
  • A specification page named _index.md following the template at:
    https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
  • For a Progress Review, that sufficient progress has been made on a Compatible Implementation and TCK, to ensure that the spec is implementable and testable.
  • For a Release Review, a summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification. The TCK users guide MUST include the instructions to run the compatible implementations used to validate the release.
    Instructions MAY be by reference.
    • Updated release record
    • Generated IP Log
    • Email to PMC
    • Start release review by emailing EMO
  • The URL of the OSSRH staging repository for the api, javadoc:
    https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/interceptor/jakarta.interceptor-api/2.2.0/
  • The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
    CDI 4.1 TCK
  • The URL of the compatibility certification request issue:
    CDI 4.1 CCR
  • Specification JavaDoc in the wombat/x.y/apidocs directory.
    If desired, an optional second PR can be created to contain just the JavaDoc in the apidocs directory.

Note: If any item does not apply, check it and mark N/A below it.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 13e7f2f
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/660d7927b976a20008b4b859
😎 Deploy Preview https://deploy-preview-702--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Mar 3, 2024
@ivargrimstad
Copy link
Member

@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Mar 12, 2024

@starksm64 I reviewed this and have the following 2 comments:

  1. change log is missing for this release.
  2. Compatible implementation says tbd. I think it should be weld-xxx.

- Specifiy Weld 6.0.0.Beta1 and the CI

Signed-off-by: Scott M Stark <[email protected]>
@starksm64
Copy link
Contributor Author

@Emily-Jiang The change log and CI have been updated.

@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Mar 13, 2024

@starksm64 I didn't see the 2.2 change log in the spec doc

Signed-off-by: Scott M Stark <[email protected]>
@starksm64
Copy link
Contributor Author

@Emily-Jiang the spec change log has been updated

@Emily-Jiang Emily-Jiang added the ballot Delivered to the Specification Committee for ballot label Mar 19, 2024
@kazumura
Copy link
Contributor

The link format of "The URL of the OSSRH staging repository" is incorrect.
Maybe brackets ('[' and ']') are not needed.

@Emily-Jiang
Copy link
Contributor

@starksm64 can you the above comments from @kazumura and @Pandrex247 before you merge this PR

@starksm64
Copy link
Contributor Author

@Emily-Jiang this has been updated as per the comments and vote comments

@mtdelgadoa
Copy link

mtdelgadoa commented Apr 4, 2024

Hello all,
the EMO is trying to avoid duplication of release records, so we will be providing our feedback and comments related to this release directly here.

Please consider adding a security file to your project repository.

EDP Review status: COMPLETED - Awaiting spec committee ballot

Release record: Jakarta Interceptors™ 2.2 Release Review

EMO review checklist

EF Specification Process

  • Spec Committee Ballot completed

Intellectual Property Management

  • All project code has copyright and license headers correctly applied. ** EMO will scan the code at their discretion **
  • All distributed third-party content has been vetted by the IP Due Diligence process (i.e., IP Log has been approved)

Open Source Rules of Engagement

  • PMC approval on the mailing list

General:

  • Project is operating within the mission and scope defined in its top-level project’s charter
  • Project is operating within the bounds of its own scope
  • Project is operating in an open and transparent manner
  • Overall the project is operating according to the Eclipse Development Process.

Things to check:

  • Communication channels advertised
  • Advertised communication channels used
  • Committers are responding to questions
  • Committers are responding to issues
  • Committers are responding to pull/merge/review requests

Branding and Trademarks
The following applies when the project has a custom website.
To the best of our knowledge:

  • Project content correctly uses Eclipse Foundation trademarks
  • Project content (code and documentation) does not violate trademarks owned by other organizations

Things to check:

  • Project website uses the project's formal name in first and all prominent references
  • Project website includes a trademark attribution statement
  • Project website footers contain all necessary elements

Legal Documentation
Required files:

  • License files in all repository roots
  • README
  • CONTRIBUTING (or equivalent)

Recommended files:

See examples for Security file and Code of Conduct.

Required elements:

  • ECA is referenced/described

Recommended elements:

Metadata (PMI)

  • The formal name, e.g. "Eclipse Foo™", is used in the project title
  • The formal name including appropriate marks (e.g, "™") is used in the first mention in the text of the project description, and scope
  • The project description starts with a single paragraph that can serve as an executive summary
  • Source code repository references are up-to-date
  • Download links and information are up-to-date (see EF handbook for more information on how-to do this)
  • Communication channels listed in the PMI (i.e. public mailing list, forums, etc.)

@Emily-Jiang Emily-Jiang added the approved The ballot was approved by the Specification Committee label Apr 10, 2024
@Emily-Jiang
Copy link
Contributor

Emily-Jiang commented Apr 10, 2024

  • On ballot completion, the specification committee mentor:
  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to [email protected]. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team:

@Emily-Jiang Emily-Jiang merged commit 7b1c584 into jakartaee:master Apr 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants