Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#77: EntityManager(Factory) should implement AutoCloseable #312

Merged
merged 2 commits into from
Apr 26, 2021
Merged

#77: EntityManager(Factory) should implement AutoCloseable #312

merged 2 commits into from
Apr 26, 2021

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Apr 20, 2021

Fixes #77

dmatej
dmatej approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I always wished this! :)

@lukasj lukasj mentioned this pull request Apr 20, 2021
Closed
m0mus
m0mus approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arjantijms
arjantijms approved these changes Apr 20, 2021
View reviewed changes
Copy link

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time :)

@tofflos
Copy link

tofflos commented Apr 22, 2021

OMG :)

@lukasj lukasj merged commit 1ae01ae into jakartaee:master Apr 26, 2021
@lukasj lukasj deleted the is77 branch April 26, 2021 08:18
@lukasj lukasj added the 3.1.0 label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0mus m0mus m0mus approved these changes

@arjantijms arjantijms arjantijms approved these changes

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EntityManager(Factory) should implement AutoCloseable
5 participants
@lukasj @tofflos @dmatej @arjantijms @m0mus