-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some extra Javax to Jakarta changes #448
Conversation
Signed-off-by: arjantijms <[email protected]>
don't you need also #446 fixed? |
Signed-off-by: arjantijms <[email protected]>
Indeed, thx! Archive now contains the service file in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@arjantijms RC5 is in staging. We will send it to central after some testing, so either let us know it's fine or wait a day. Thx |
* Some extra Javax to Jakarta changes Signed-off-by: arjantijms <[email protected]> * Rename javax.* service files to jakarta.* Signed-off-by: arjantijms <[email protected]>
Updated some occurrences of
javax
tojakarta
. Especially themail/src/main/resources/META-INF/hk2-locator/default
is important, as it prevents GlassFish from starting.Signed-off-by: arjantijms [email protected]