Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#240] fixes parseBoolean according spec #279

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[#240] fixes parseBoolean according spec #279

merged 1 commit into from
Sep 13, 2023

Conversation

laurentschoelens
Copy link
Contributor

Fixes #240 : parseBoolean function could return true or false value when, according to spec, it should not accept the string literal as valid boolean expression

Adding UT to validate behaviour

@laurentschoelens laurentschoelens mentioned this pull request Sep 12, 2023
Merged
lukasj
lukasj approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit b023399 into jakartaee:master Sep 13, 2023
2 checks passed
@laurentschoelens laurentschoelens deleted the gh-240 branch September 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

javax.xml.bind.DatatypeConverter.parseBoolean("10") returns true instead of false or an Exception
2 participants
@laurentschoelens @lukasj