Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlb-12, xmlb-13, xmlb-8 and xmlb-25 are recreated in SVG format. xmlb-15 is recreated in PNG format. #221

Merged
merged 13 commits into from
Feb 17, 2022

Conversation

DmitriGit
Copy link
Contributor

Done.

Three images are missing to convert now. Hope tomorrow commit these three images.

Dmitri.

@DmitriGit DmitriGit changed the title xmlb-12 and xmlb-13 are recreated in SVG format xmlb-12, xmlb-13, xmlb-8 and xmlb-25 are recreated in SVG format. xmlb-15 is recreated in PNG format. Feb 16, 2022
@DmitriGit
Copy link
Contributor Author

All images are recreated.

Now you have a very nice Specification. :)

Dmitri.

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the text in "built-in primitive types" (xmlb-15.png) be in white (or colors be changed/updated) so it becomes readable? Having black text on the black background can be challenging to read in the dark room in the evening :-) The most readable version of the picture I've found is in the version 2 of the original spec at https://download.oracle.com/otndocs/jcp/jaxb-2.0-fr-eval-oth-JSpec/

@DmitriGit
Copy link
Contributor Author

:)))) I'm very sorry, Lukas!!!

Don't know how I commited a picture like this! :))
Sorry...

Tomorrow you'll have a picture in SVG format and we are OK. :)

Dmitri.

@DmitriGit
Copy link
Contributor Author

Look my commit 1 minute ago. Tell me, please, if that version is OK.

Dmitri.

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is it! Thanks a lot!
LGTM

@lukasj lukasj merged commit 997005c into jakartaee:master Feb 17, 2022
@DmitriGit
Copy link
Contributor Author

Ok, I'm happy!

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants