Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jakarta.inject 1.0 is an explicit java module or at least reserves its automatic module name #14

Closed
tomdw opened this issue Apr 3, 2020 · 4 comments
Assignees

Comments

@tomdw
Copy link

tomdw commented Apr 3, 2020

If the community is to succeed in migrating to java modules then the basic dependencies such as javax.inject or jakarta.inject should at least reserve their automatic module name.

See http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-October/013233.html for a discussion on what that name could be. Suggested: 'java.inject'

A new release on maven central of jakarta.inject 1.0 should become available.

(also logged in javax-inject/javax-inject#33 some time ago)

@starksm64
Copy link
Contributor

A 1.0.1 release was created with an Automatic-Module-Name: jakarta.inject has been made

@tomdw
Copy link
Author

tomdw commented Apr 30, 2020

@starksm64 sure that ‘jakarta.inject’ is correct? For version 2 as part of jakarta ee 9 yes, but for jakarta ee 8 the module name should be ‘java.inject’ i think. Also other previous javax jars have such automatic module names (e.g. java.ws.rs for the jaxrs api).

@starksm64 starksm64 reopened this Jul 27, 2020
@starksm64
Copy link
Contributor

Yes, you are correct.

starksm64 added a commit that referenced this issue Jul 30, 2020
@starksm64
Copy link
Contributor

Automatic-Module-Name has been updated to java.inject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants