Use hasattr() rather than isinstance(value, MutableSequence) #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where the code checks specifically if something is an instance
MutableSequence
. I believe the more pythonic way would be something like:From what I can see, iterability is what is actually desired, the other functionality of
MutableSequence
isn't needed.For example, I have an object which is iterable and should therefore (AFAIK) be able to be decoded into a collection. However, right now it fails the check for being a
MutableSequence
.This is potentially an extension of issue #18 from last year.