Added instructions for deploying to Heroku. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Heroku | ||
| ****** | ||
| You can also run the server on `Heroku <https://heroku.com>`_ by adding ``gunicorn`` to ``requirements.txt`` | ||
| and creating a ``Procfile`` with ``web: gunicorn --pythonpath youtube_dl_server app:app -w 4 --log-file -``. |
There was a problem hiding this comment.
I'm going to include a default Procfile in the main repo, do you think the -w option can be ommitted?, it's not mentioned in the heroku docs.
There was a problem hiding this comment.
Hmm, you're right!
In https://devcenter.heroku.com/articles/python-gunicorn#basic-configuration:
The WEB_CONCURRENCY environment variable is automatically set by Heroku, based on the
processes' Dyno size. This feature is intended to be a sane starting point for your
application. We recommend knowing the memory requirements of your processes and setting
this configuration variable accordingly.
So I guess it's best that we leave -w out. 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some instructions for deploying to Heroku, an alternative to GAE.