Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Slash commands #664

Open
diwako opened this issue Apr 2, 2021 · 42 comments
Open

[Feature Request] Slash commands #664

diwako opened this issue Apr 2, 2021 · 42 comments
Milestone

Comments

@diwako
Copy link

diwako commented Apr 2, 2021

Is your feature request related to a problem? Please describe.
Discord recently added slash commands. That is when you just type in / and it shows you all kind of operations possible on a discord server.
https://discord.com/developers/docs/interactions/slash-commands

Describe the solution you'd like
As a user I want to be able to use slash commands to play, skip or stop music from the music bot

Describe the basic flow/steps of using this feature
How this feature would be used:

  1. Type / into chat or press the slash button
  2. See a list of commands available from the music bot
  3. Select a command or press "tab" to auto complete it
@omsenjalia
Copy link

This is a great idea

@ottowong
Copy link

would love to see this too

@TheGreatestJannet
Copy link

According to discord.py apparently it is required to add them by 2022 or the bot will stop working: https://gist.github.com/Rapptz/4a2f62751b9600a31a0d3c78100287f1?a

@bup0441
Copy link

bup0441 commented Aug 28, 2021

Danny is right about the potential breakage of the Message Content Intent and needing slash commands if your bot is big enough, but this only applies to bots in more than 100 servers or verified bots. JMusicBots by design should not be used in more than a few servers at a time, so the Message Content Privileged Intent will not affect their function.

@TheGreatestJannet
Copy link

Oh I see. Thanks a lot for clarifying!

@MichailiK
Copy link
Collaborator

It was even planned to make the bot refuse to launch on verified bots.

@DJMoffinz
Copy link

DJMoffinz commented Sep 13, 2021

Good idea. Great minds think alike, it would seem.

@Codeize
Copy link

Codeize commented Sep 13, 2021

It was even planned to make the bot refuse to launch on verified bots.

This is a really cheap incentive by Discord to force everyone to use their half baked system imo

@MichailiK
Copy link
Collaborator

MichailiK commented Sep 13, 2021

It was even planned to make the bot refuse to launch on verified bots.

This is a really cheap incentive by Discord to force everyone to use their half baked system imo

idk if you understand what im saying: we may plan to bake in a check if the bot is verified & refuse to launch, saying musicbot isnt intended for large scale.

@Codeize
Copy link

Codeize commented Sep 13, 2021

It was even planned to make the bot refuse to launch on verified bots.

This is a really cheap incentive by Discord to force everyone to use their half baked system imo

idk if you understand what im saying: we may plan to bake in a check if the bot is verified & refuse to launch, saying musicbot isnt intended for large scale.

Ah I see, my apologies

@MichailiK
Copy link
Collaborator

Technical side note: This will likely require an update from JDA-Utilities, which is the command handler JMusicBot uses.

@lilchancep
Copy link

lilchancep commented Oct 4, 2021

My apologies if I reading this wrong but it looks like support for slash commands was added on June 4th. Pull#1501

@MichailiK
Copy link
Collaborator

MichailiK commented Oct 4, 2021

JDA-Utilities is responsible for handling commands in JMusicBot, so JDA-Utilities needs to be updated first.

@Chew
Copy link

Chew commented Oct 12, 2021

JDA-Chewtils (fork of the above) has support for it. I know jag made the original lib so if he's fine with me switching to mine (or merging it into his) I can get it added to this bot very easily.

@ghost
Copy link

ghost commented Mar 21, 2022

My bot is present on 150 servers but only a few at a time ever use the bot simultaneously. It would save me a lot of stress if this bot could support slash commands.

@jagrosh
Copy link
Owner

jagrosh commented Mar 21, 2022

Using slash commands isn't really related to how many servers a private bot is on; it doesn't really change the functionality, and if used at the same time as non-slash commands, could potentially (slightly) worsen performance.

That being said, JMusicBot will add slash command support after JDA-Utils is updated to support them. This update is currently in-progress.

As a final note, JMusicBot is not intended to be run as a public bot, and running a copy of JMusicBot on more than 75 servers is not supported. Many systems in the bot are designed around maximum per-server quality (as would be expected for a private, self-hosted music bot), rather than being highly scalable. Because of this expectation, if a feature was added that required something only possible on a private bot, JMusicBot would become unusable on a public/large-server-count bot. If you're trying to run a public music bot, you're much better off writing your own bot from scratch that is designed to scale accordingly.

@ghost
Copy link

ghost commented Mar 21, 2022 via email

@jagrosh
Copy link
Owner

jagrosh commented Mar 21, 2022

Considering that the JDA-Utils slash command update is still in-progress, slash commands on JMusicBot will certainly not be ready before next month. You will need to create additional bot accounts and run multiple copies of JMusicBot if you intend to support more than 75 servers. Additionally, JMusicBot may be unusable on verified bots in the future, as the person running the bot is not the developer of the bot, as implied by the verification system.

@ghost
Copy link

ghost commented Mar 27, 2022

Understood, thank you for your responsiveness and detailed replies.

@evanw555
Copy link

evanw555 commented Apr 6, 2022

I'm running a private instance of this bot for 1 private server, so the privileged message intents problem is not present for me. My biggest concern is the spam generated by using plaintext message commands (it annoys members of my server).

Once slash commands are in development, I'm hoping that there will be a configuration option for making all command replies ephemeral (i.e. only show the response to the user sending the command). This would reduce a lot of the noise generated by this bot on my server. Furthermore, it would be great if the admin could disable plaintext message commands, as I'd like to reduce the spam ASAP.

Thanks for continuing to update this bot, and thanks for your intent to support slash commands.

@arnon001
Copy link

(first for 2023)
when this will be updated?

@sedric
Copy link

sedric commented Jan 28, 2023

JDA-Utils seems dormant : last commit is a year old now. May it be removed from dependencies as you did for GiveawayBot ?

@jagrosh
Copy link
Owner

jagrosh commented Jan 31, 2023

JDA-Utils is still necessary for JMusicBot, and JMusicBot will get slash command support when I finish my JDA5 update for JDA-Utils

@Shiny1708
Copy link

Any updates on this?

@Grant-K
Copy link

Grant-K commented Mar 25, 2023

Any updates on this?

I second this been about 2 months since last update on implementation would be very nice to keep things uniform

@MichailiK
Copy link
Collaborator

We’re still awaiting JDA-Utilities updates.

@Grant-K
Copy link

Grant-K commented Mar 25, 2023

We’re still awaiting JDA-Utilities updates.

They are kinda far behind considering when slashs were announced and enforced but fair enough i believe thats a free time project

@jagrosh
Copy link
Owner

jagrosh commented Mar 25, 2023

Both this and JDA Utils are "free time projects," and I'm about 70% finished with the slash commands update for JDA Utils

@Grant-K
Copy link

Grant-K commented Mar 25, 2023

Both this and JDA Utils are "free time projects," and I'm about 70% finished with the slash commands update for JDA Utils

Much Obliged just read the documentation seems like alot of code change required pretty much re doing most commands

@Grant-K

This comment was marked as off-topic.

@userzfr
Copy link

userzfr commented Apr 17, 2023

It's a very good idea

@GeorgesAlkhouri
Copy link

Thanks for the time you put in!

@othello777
Copy link

it looks like Pull#1501 got merged. does that mean there is slash command support now? I reinvited my bot with applications.commands permissions, but it didnt seem to do much

@jagrosh
Copy link
Owner

jagrosh commented Sep 7, 2023

it looks like Pull#1501 got merged. does that mean there is slash command support now? I reinvited my bot with applications.commands permissions, but it didnt seem to do much

This is irrelevant, support has not been added yet because I am still working on the JDA-Utils update.

@LostOfficial
Copy link

Any updates?

@MichailiK
Copy link
Collaborator

There is still work being done on a JDA-Utils update.

@Lovasz-Akos
Copy link

can't wait for this

@BarkerB
Copy link

BarkerB commented Jun 11, 2024

Really looking forward to this feature, thanks for all your hard work with JDA Utils and JMusicBot!

@MichailiK MichailiK added this to the 0.5.0 milestone Sep 16, 2024
@Zammer8
Copy link

Zammer8 commented Sep 20, 2024

@jagrosh Any plans for adding this? I'd love it! It would also let us customize each command's permissions easily, with the Integrations tab, which lets people control Slash Command Perms.

@Screenmax1234
Copy link

Dead as of now!

@MichailiK
Copy link
Collaborator

Truly. Merry Christmas!

@othello777
Copy link

it's true, but it is open source so you can fork it and add it if you want. also despite what it may seem the bot still does work if you update the youtube_source portion of lavaplayer to the newest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests